Add new "GameMode" option which implements org.freedesktop.portal.GameMode #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option adds first-class gamemode support into Vinegar via the use of desktop portals. https://docs.flatpak.org/en/latest/portal-api-reference.html#gdbus-org.freedesktop.portal.GameMode Enabled by default
|
Systems without dbus and/or desktop portals will simply not use this new functionality. There should be no regressions. |
apprehensions
requested changes
Nov 23, 2023
Co-authored-by: sewn <[email protected]> Signed-off-by: Jrelvas <[email protected]>
This reverts commit 51c48f4.
Co-authored-by: sewn <[email protected]> Signed-off-by: Jrelvas <[email protected]>
Co-authored-by: sewn <[email protected]> Signed-off-by: Jrelvas <[email protected]>
it was completely useless lmao
|
I've applied your feedback and suggestions. I'm ready for a second review. |
Signed-off-by: Jrelvas <[email protected]>
Signed-off-by: Jrelvas <[email protected]>
apprehensions
requested changes
Nov 24, 2023
jrelvas-ipc
commented
Nov 24, 2023
Co-authored-by: sewn <[email protected]> Signed-off-by: Jrelvas <[email protected]>
Signed-off-by: Jrelvas <[email protected]>
apprehensions
approved these changes
Nov 24, 2023
follows vinegar code style choices better
Signed-off-by: Jrelvas <[email protected]>
this sounds way better Signed-off-by: Jrelvas <[email protected]>
lunarlattice0
approved these changes
Nov 27, 2023
|
It is actived by default or we need to activate it? |
|
It's active by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users have to manually edit configuration to use gamemode by setting a custom launcher. This is bad because the majority of distros have gamemode present. Furthermore, our flatpak requires an extension to be installed separately for
gamemoderunto be available, which further degrades user experience.This PR fixes that by implementing support for requesting gamemode to be enabled via desktop portals, which is done by default (for both player and studio). This should work out of the box for most distros and for flatpak installs.
Note: VinegarBridge will depend on the new
internal/buspackage for some of its functionality, so this PR is a prerequisite for implementing it.