Show git head sha in sysinfo output #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Vinegar is built with head's latest commit sha, which is shown in sysinfo's output. If the sha can't be determined (for instance, if vinegar was built from a tarball with no git info), it's displayed as N/A
|
This is up to the user. I have requested the AUR git package maintainer for example to implement this via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have no way of telling apart users which are using packaged Vinegar from users which are building vinegar from source. Any potential reports they make will apply to a specific point of our master branch instead of stable releases.
This PR fixes that issue by building Vinegar with the current git head's sha1 and displaying it as part of sysinfo's output, allowing us to identify if the user isn't on a stable release and at what precise point of history their Vinegar binary was built on.
If the sha can't be fetched during build time (for example, if git isn't installed or the user isn't building from a git repository), then N/A is shown.