[HELP WANTED] Fix for System Menu Styles for Gnome 48

[marmitar]

For a clean diff, see marmitar/Orchis-theme#1

This is a fix for #514 and #516. The fix does work overall, but it has some coloring issues.

Any opinion or help here would be appreciated. You can find all changes for Gnome 48 themes on this diff. The important file is src/_sass/gnome-shell/widgets/_quick-settings-48.scss. My changes are on the last two wip commits.

Visual Reference

Here's the base fix:

Notice that new separator there? I didn't know which color to use, so I removed it:

Here you can see that the arrow has a different background color from the button when unchecked, but the same color when checked. Since I don't know the colors used before, I decide to just use the button colors for everything. Here's how it looks:

So that's the current state of this fix.

[jrangelardila]

Hello @marmitar

Your changes, worked very well in Arch with gnome 48.

Thanks!

[masterdokuro]

Thanks for taking the time to look at this. However, this fix changes the blue colour of the part of the button which has the -> arrow. You can see in the screenshot I included in #514 that right hand side of the button has a lighter blue to the rest of the button. I think in the spirit of this theme we would want to keep that styling with any fix being made to gnome 48 so it matches what we have today with gnome 47.

Again, thanks for looking into this.

[marmitar]

Hi, @masterdokuro, thanks for taking a look at this.

Yes, the color needs to be fixed, but I'm not sure which color to use there. It wasn't defined in quick-toggle-arrow before, so it was probably selected by another CSS class. This change was implemented on gnome-shell!3554, I'll take a look there to see if I can find out how it was styled before.

About the icon, I don't think we can change it. It's defined as go-next-symbolic even before Gnome 47 (see quickSettings.js). That icon is a chevron on both Adwaita and Tela Circle (the one I'm using and developed by @vinceliuice), so I'm not sure how you got an arrow there. Are you maybe using another icon theme for that?

[masterdokuro]

The icon itself comes from the icon theme I use (papirus), so ignore that. Sorry if I confused you mentioning the icon, its not important to this issue. Its the colour of that part of the button which is important.

I'll take a look around and see if I can figure out what colour it is.