Fixup

vimeo · Feb 18, 2025 · 298d3cc · 298d3cc
1 parent 9238574
commit 298d3cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="6.x-dev@c48158beaa48190a4ddcd84bae16f4f909895143">
+<files psalm-version="6.x-dev@c424cac5d8d8492cb430bcad7aeda4b5d2ca6355">
   <file src="examples/TemplateChecker.php">
     <PossiblyUndefinedIntArrayOffset>
       <code><![CDATA[$comment_block->tags['variablesfrom'][0]]]></code>
@@ -1639,6 +1639,9 @@
       <code><![CDATA[empty($baselineFile)]]></code>
       <code><![CDATA[getenv('PSALM_SHEPHERD')]]></code>
     </RiskyTruthyFalsyComparison>
+    <UnusedPsalmSuppress>
+      <code><![CDATA[PossiblyNullArgument]]></code>
+    </UnusedPsalmSuppress>
   </file>
   <file src="src/Psalm/Internal/Cli/Psalter.php">
     <RiskyTruthyFalsyComparison>

diff --git a/src/Psalm/Internal/Cli/Psalm.php b/src/Psalm/Internal/Cli/Psalm.php
@@ -1029,7 +1029,7 @@ private static function restart(array $options, int $threads, int $scanThreads,
         }
     }
 
-    /** @psalm-suppress UnusedParam $argv is being reported as unused */
+    /** @param array<int, string> $argv */
     private static function forwardCliCall(array $options, array $argv): void
     {
         if (isset($options['alter'])) {
@@ -1040,9 +1040,9 @@ private static function forwardCliCall(array $options, array $argv): void
 
         if (isset($options['review'])) {
             require_once __DIR__ . '/Review.php';
-            assert($argv !== null);
             array_shift($argv);
-            Review::run($argv);
+            /** @psalm-suppress PossiblyNullArgument */
+            Review::run(array_values($argv));
             exit;
         }