Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to load newer sxscatalog files #204

Merged
merged 19 commits into from
Oct 22, 2023
Merged

add method to load newer sxscatalog files #204

merged 19 commits into from
Oct 22, 2023

Conversation

md-arif-shaikh
Copy link
Collaborator

load_sxs_catalogformat is modified to allow loading sxs waveform files in the new format.

gw_eccentricity/load_data.py Outdated Show resolved Hide resolved
gw_eccentricity/load_data.py Outdated Show resolved Hide resolved
@md-arif-shaikh

This comment was marked as resolved.

gw_eccentricity/load_data.py Show resolved Hide resolved
gw_eccentricity/load_data.py Outdated Show resolved Hide resolved
gw_eccentricity/load_data.py Outdated Show resolved Hide resolved
gw_eccentricity/load_data.py Show resolved Hide resolved
gw_eccentricity/load_data.py Outdated Show resolved Hide resolved
@vijayvarma392
Copy link
Owner

Also, talk about the Horizons.h5 file in the notebook:
image

Think of it from the perspective of a new user -- you need to tell them which whiles are good to include.

And make sure the docs printed in the notebook are up to date:
image
This should already be explaining what new/old means.

@md-arif-shaikh
Copy link
Collaborator Author

Also, talk about the Horizons.h5 file in the notebook: image

Think of it from the perspective of a new user -- you need to tell them which whiles are good to include.

And make sure the docs printed in the notebook are up to date: image This should already be explaining what new/old means.

I will run and push the updated notebook once the orbit thing is fixed.

@vijayvarma392 vijayvarma392 merged commit 4e1b899 into main Oct 22, 2023
3 checks passed
@vijayvarma392 vijayvarma392 deleted the load_new_sxs branch October 22, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants