Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative, local URLs for fonts. #364

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Conversation

lechten
Copy link
Contributor

@lechten lechten commented Apr 28, 2020

Partially addresses issue #360.

@viebel
Copy link
Owner

viebel commented Jun 2, 2020

Thanks for your PR @lechten
The problem is that files under the dist folder are generated by this build script: https://github.com/viebel/klipse/blob/master/scripts/build#L16

You need to make your modifications in the build script.

@lechten
Copy link
Contributor Author

lechten commented Jun 5, 2020

The new commit applies the change to the source file that is copied in the build script.

@viebel
Copy link
Owner

viebel commented Jun 5, 2020

The problem now is that the css is broken in the case where Klipse is not hosted locally.
The fix should be in the build script: replace the urls before copying codemirror.css to the dist folder

@lechten
Copy link
Contributor Author

lechten commented Jun 5, 2020

Ah, I hope this is what you had in mind.

@viebel
Copy link
Owner

viebel commented Jun 6, 2020

That's exactly what I had in mind.
Thank you for improving Klipse

@viebel viebel merged commit e80ee6a into viebel:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants