Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when hosting Klipse locally, fonts are loaded from the internet #360

Open
lechten opened this issue Apr 23, 2020 · 5 comments
Open

when hosting Klipse locally, fonts are loaded from the internet #360

lechten opened this issue Apr 23, 2020 · 5 comments

Comments

@lechten
Copy link
Contributor

lechten commented Apr 23, 2020

Hi, I'm using the master version, following "Host Klipse locally". Differently from #334, I'm using the non-minified version here.

If I add klipse_settings.no_dynamic_scripts=true;, evaluation of code fails with: TypeError: a.split is not a function, while it (almost) works without that setting.

The piece that is not working is that I see a web request for https://viebel.github.io/klipse/fonts/FiraCode/woff/FiraCode-Regular.woff. This request should not be necessary as that resource is part of the dist directory. How can I avoid this?
@viebel
Copy link
Owner

viebel commented Apr 27, 2020

That's definitely a bug.
You can fix it by modifying this file: https://github.com/viebel/klipse/blob/57e5312e88425811183a838f63afd4a92077fada/dist/codemirror.css

Please provide a PR.

lechten added a commit to lechten/klipse that referenced this issue Apr 28, 2020
@lechten
Use relative, local URLs for fonts.
b90a014 
Partially addresses issue viebel#360.
@lechten lechten mentioned this issue Apr 28, 2020
Merged
@lechten
Copy link
Contributor Author

lechten commented Apr 28, 2020

I opened a PR for the font issue.

When should klipse_settings.no_dynamic_scripts=true; be necessary?

@viebel viebel changed the title TypeError: a.split is not a function with no_dynamic_scripts: true when hosting Klipse locally, fonts are loaded from the internet Jun 2, 2020
viebel pushed a commit that referenced this issue Jun 6, 2020
@lechten
Use relative, local URLs for fonts. (#364)
e80ee6a 
* Use relative, local URLs for fonts.

Partially addresses issue #360.
@workshub
Copy link

workshub bot commented Apr 30, 2021

@Verdinjoshua26 started working on this issue via WorksHub.

@workshub
Copy link

workshub bot commented May 27, 2021

@rainbow-bamboo started working on this issue via WorksHub.

@workshub
Copy link

workshub bot commented Jul 10, 2021

A user started working on this issue via WorksHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viebel @lechten