Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lyrics support but not happy for merge #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neoedmund
Copy link

I made the just work patch for adding lyrics function for audio.

But I'm sorry about the "dirty" code, so It will not be merged to the original repo. But anyone need the lyrics is welcome to download the apk from the release section of this repo.

support .lrc external lyrics
support for remember play position for each audio is not work (why?)
small issue like lyrics not shown when pause is pressed

Thanks

@PomepuyN
Copy link
Contributor

Thanks a lot for your pull request! It would be an interesting addition to the app.

Unfortunately, this repository is only a mirror and all request should be done on https://code.videolan.org/videolan/vlc-android/-/merge_requests

Could you please open it there? If you need any help to migrate this request to our Gitlab, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants