Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix angular not building in video.js version 8 reported in #8141
Specific Changes proposed
sass was erroring out for me when running
npm run build
on the stepsbuild:css:cdn
andbuild:css:default
.This seemed to cause the build not to get to
build:types
.In my local 8.2.1 video.js in angular, there is no file
./dist/types/video.d.ts
.My guess is that it's due to this build failure.
I haven't checked whether this affects building using yarn....
We don't use yarn.
Requirements Checklist