-
Notifications
You must be signed in to change notification settings - Fork 431
Audio only exclude #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio only exclude #1565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 83.96% 83.99% +0.02%
==========================================
Files 44 44
Lines 11681 11699 +18
Branches 2611 2618 +7
==========================================
+ Hits 9808 9826 +18
Misses 1873 1873 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. We definitely should not be including demuxed audio with video playlists.
Description
We might encounter situations when we have a main playlist with audio-only and video-only or muxed renditions. VHS does not support switching between audio-only and video-only or muxed, so we want to exclude audio-only renditions if we have renditions with video.
Specific Changes proposed
Requirements Checklist