Skip to content

Pass Event::User.type_ to SDL_UserEvent.r#type in Event::to_ll #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pass Event::User.type_ to SDL_UserEvent.r#type in Event::to_ll #157

wants to merge 3 commits into from

Conversation

Gambloide
Copy link
Contributor

fixes #155

My rationale for the suggested change is explained in my comments in the same issue.

After applying this change, all src/sdl3/event.rs tests are green, but the following modules report FAILED tests.
However, this seems to be because they weren't ran prior to this change, rather than a regression.

src/sdl3/audio.rs
src/sdl3/keyboard/mod.rs
src/sdl3/render.rs
src/sdl3/surface.rs
src/sdl3/video.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests/events.rs::test2 fails because sdl3::event::Event::to_ll overwrites type of sdl3::event::Event::User
1 participant
@Gambloide