Do the setup and arch determination necessary to build old htslib on autoconf 2.70+ #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jltsiren is right that really we will need to upgrade vcflib to the current htslib-less version, and ship tabixpp and maybe htslib separately, but this seems to fix the build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
This should fix the Mac CI build; Homebrew started shipping Autoconf 2.70, the first update in about 8 years, this week.
The htslib PR for fixing this in the install instructions is at samtools/htslib#1199 and hopefully that change will eliminate the need to manually use the host architecture guesser.