Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit name parameter #44

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

kokorins
Copy link
Contributor

I would like to cover next case which I'm actively use to minimize the dot files:

digraph name {
    fontsize=48
    bgcolor="transparent"

    rankdir=LR;
    node [shape=box, style="rounded,filled", fillcolor="#333333", fontcolor="#ffffff"];

    {node [fillcolor="#952877"; color="#952877"]; purple} // <- this will be applied to all nodes in same group
    purple [label="Purple background with rounded corners"]
}

I propose to do minimal changes and extend DotNode element to accept any name including ones that needs to be quoted.

@kokorins kokorins changed the title Add explit name parameter Add explicit name parameter Jul 2, 2024
@kokorins
Copy link
Contributor Author

kokorins commented Jul 2, 2024

@vfrz Can you please have a look on one small proposal =)

@vfrz
Copy link
Owner

vfrz commented Jul 13, 2024

Sorry for the delay, looks good enough for me! Thanks for the contribution.

@vfrz vfrz merged commit 7b014c3 into vfrz:master Jul 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants