Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "advanced" LoggerFormatter API to expose more request metadata #2368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guss77
Copy link
Contributor

@guss77 guss77 commented Feb 23, 2023

As LoggerHandlerImpl already calculated this important information, that is otherwise hard/impossible to get (e.g. request start time), so if we want to use that metadata in a formatter (e.g. to mimic LoggerFormat.DEFAULT) - it'd be best if we don't need to repeat work that had already been done.

I'm not happy with the new class's name - I'm just drawing a complete blank on what would be a good name. Suggestions are welcome 😅 .

Motivation:

Implement the feature request in issue #2367

As LoggerHandlerImpl already calculated this important information, that
is otherwise hard/impossible to get (e.g. request start time), so if we
want to use that metadata in a formatter (e.g. to mimic
LoggerFormat.DEFAULT) - it'd be best if we don't need to repeat work
that had already been done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant