fix(mfe): build internal package if present in graph #9383
Merged
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
commented
Nov 5, 2024
| @@ -57,6 +57,11 @@ impl From<UnescapedString> for String { | |||
| } | |||
| } | |||
|
|
|||
| impl From<String> for UnescapedString { | |||
There was a problem hiding this comment.
Required since there isn't any other way to construct an UnescapedString
chris-olszewski
commented
Nov 5, 2024
| @@ -184,7 +186,10 @@ impl TurboJsonLoader { | |||
| Error::NoTurboJSON => Ok(TurboJson::default()), | |||
| err => Err(err), | |||
| })?; | |||
| turbo_json.with_proxy(); | |||
| let needs_proxy_build = packages | |||
There was a problem hiding this comment.
We only want to add this if the internal package is in the graph meaning there's a valid build task
tknickman
approved these changes
Nov 5, 2024
| @@ -619,6 +620,11 @@ impl TurboJson { | |||
| TaskName::from("proxy"), | |||
| Spanned::new(RawTaskDefinition { | |||
| cache: Some(Spanned::new(false)), | |||
| depends_on: needs_proxy_build.then(|| { | |||
| Spanned::new(vec
There was a problem hiding this comment.
Don't love that we have to hardcode this task, but we can iterate on it.
There was a problem hiding this comment.
I also don't love this, but for all other uses of the MFE package that don't have it as a workspace package this will be unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were relying on the proxy already being built, for non-internal use cases this will be true, but for the internal case we need to make sure it is built before we try to start the proxy.
Testing Instructions
packages/micro-frontends/dist/bin/cli.cjsand add athrow new Error("oops")to the topturbo vercel-docs#devshould fail due to the proxy script failingturbo:turbo_dev --skip-infer vercel-docs#dev, you will see the MFE package being built before the proxy is started.