-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): bug in design system example #9284
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
@@ -8,7 +8,8 @@ | |||
"format": "prettier --write \"**/*.{ts,tsx,md}\"", | |||
"changeset": "changeset", | |||
"version-packages": "changeset version", | |||
"release": "turbo run build --filter=docs^... && changeset publish" | |||
"release": "turbo run build --filter=docs^... && changeset publish", | |||
"preview-storybook": "turbo preview-storybook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's not related to this PR (as in, maybe it's already happening before this PR) but this 404's for me. does it work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimitropoulos If you see fit, I could add this script in another merge request too. About the 404, you have to run the build script before the preview-storybook. Let me know if there was another thing going on.
…ign-system Co-authored-by: Dimitri Mitropoulos <[email protected]>
Description
preview-storybook
task to turbo.json and it's script in the root's package.json@acme/ui
package not to make source map files in order to match the content ofui/dist
directory stated in README of rootacme-core
and other names that meant to point to packages/ui with@acme/ui
Testing Instructions
Running
npx create-turbo@latest -e design-system
and thenpnpm dev
should work and start storybook in dev mode. README.md file in the root should be fine too.