fix(examples): bug in design system example #9284
Open
+56
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
|
@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
zsh77
changed the title
| @@ -8,7 +8,8 @@ | |||
| "format": "prettier --write \"**/*.{ts,tsx,md}\"", | |||
| "changeset": "changeset", | |||
| "version-packages": "changeset version", | |||
| "release": "turbo run build --filter=docs^... && changeset publish" | |||
| "release": "turbo run build --filter=docs^... && changeset publish", | |||
| "preview-storybook": "turbo preview-storybook" | |||
There was a problem hiding this comment.
maybe it's not related to this PR (as in, maybe it's already happening before this PR) but this 404's for me. does it work for you?
There was a problem hiding this comment.
@dimitropoulos If you see fit, I could add this script in another merge request too. About the 404, you have to run the build script before the preview-storybook. Let me know if there was another thing going on.
…ign-system Co-authored-by: Dimitri Mitropoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
preview-storybooktask to turbo.json and it's script in the root's package.json@acme/uipackage not to make source map files in order to match the content ofui/distdirectory stated in README of rootacme-coreand other names that meant to point to packages/ui with@acme/uiTesting Instructions
Running
npx create-turbo@latest -e design-systemand thenpnpm devshould work and start storybook in dev mode. README.md file in the root should be fine too.