Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rust 1.81.0 #9139

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: support rust 1.81.0 #9139

merged 2 commits into from
Sep 13, 2024

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Sep 13, 2024

Description

  • features fs_try_exists and panic_info_message are stable
  • fs::try_exists is now fs::exists
  • PanicInfo is now PanicHookInfo (use to_string method for it)
  • switch to 1.81.0-nightly in rust-toolchain.toml

Testing Instructions

cargo test to ensure the code has the same behavior as before

@ognevny ognevny requested a review from a team as a code owner September 13, 2024 08:27
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Sep 13, 2024
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 5:27pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:27pm

Copy link

vercel bot commented Sep 13, 2024

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Sep 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 67f223c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ognevny
Copy link
Contributor Author

ognevny commented Sep 13, 2024

should be clippy fixes be pushed along with this change?

@chris-olszewski
Copy link
Member

should be clippy fixes be pushed along with this change?

If you could do that, it would be very much appreciated. It looks like those lints just got added.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me, the new clippy lints just need to be fixed.

@ognevny
Copy link
Contributor Author

ognevny commented Sep 13, 2024

done, fixed all errors and warnings

@chris-olszewski chris-olszewski enabled auto-merge (squash) September 13, 2024 17:41
@chris-olszewski chris-olszewski merged commit 86f389c into vercel:main Sep 13, 2024
39 of 40 checks passed
@ognevny ognevny deleted the rust-1.81.0 branch September 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants