Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove turbopack top level crates #9119

Merged

Conversation

chris-olszewski
Copy link
Member

Description

Removing all top level dependencies that don't appear in our Cargo.lock:

List of crates to remove generated via

$ tail -n+42 < Cargo.toml | cut -d' ' -f1 > /tmp/top_level_crates.txt
$ rg -F -f /tmp/top_level_crates.txt Cargo.lock -o -N | sort -u > /tmp/matches.tx
$ rg -F -f /tmp/matches.txt -v /tmp/top_level_crates.txt

Testing Instructions

Everything builds and passes on CI

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 3:35pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-gatsby-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-native-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-svelte-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-tailwind-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm
examples-vite-web ⬜️ Ignored (Inspect) Sep 6, 2024 3:35pm

@chris-olszewski chris-olszewski marked this pull request as ready for review September 6, 2024 15:35
@chris-olszewski chris-olszewski requested a review from a team as a code owner September 6, 2024 15:35
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is ✅ I'm ✅

@chris-olszewski chris-olszewski enabled auto-merge (squash) September 6, 2024 15:37
@chris-olszewski chris-olszewski merged commit 785682b into main Sep 6, 2024
37 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_remove_unused_top_level_crates branch September 6, 2024 15:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants