feat(turborepo): web ui #8895
Merged
feat(turborepo): web ui #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
NicholasLYang
commented
Jul 31, 2024
|
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
c857ccc
to
1abcc6b
Compare
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
1abcc6b
to
23fd9b2
Compare
turbo-orchestrator
bot
removed
the
area: examples
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
6592b5f
to
96183a6
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
96183a6
to
76fed76
Compare
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
2221f05
to
21dc102
Compare
chris-olszewski
requested changes
Sep 10, 2024
| pub async fn start_server( | ||
| rx: tokio::sync::mpsc::UnboundedReceiver<WebUIEvent>, | ||
| ) -> Result<(), crate::Error> { | ||
| let state = Arc::new(Mutex::new(RefCell::new(WebUIState::default()))); |
There was a problem hiding this comment.
I'm not sure if I understand the use of RefCell inside of the Mutex. Doesn't the Mutex already ensure that there's only ever one access to the underlying data at a time? Why are dynamic borrows necessary inside of the restriction?
If this is necessary a quick comment explaining why would be very appreciated.
There was a problem hiding this comment.
It's so Subscriber can mutate the state even though it's behind an immutable reference. We can't have a mutable reference because Query also needs to hold a reference to it.
chris-olszewski
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a very very alpha version of a web UI. Uses a GraphQL query to get the current run and tasks.
Testing Instructions
Would love some ideas here on tests.
To try out manually, go to #35066 in the other repo and run
turbo-studio, then execute a turbo command with theuiflag set toweb