fix(cli): prevent splitting of run args #8893
Draft
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
|
Moving back to draft as flags set via environment variables end up in both sets of execution args. Need a different approach to checking if both are used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a bug where we allowed providing run flags on either side of the
runsubcommand e.g.turbo --filter=web run build. Any arguments provided beforerunwould be silently ignored in this case.Background
We support omitting the
runsubcommand so we duplicate all of the run subcommand arguments on the mainturbocommand. This allowed for users to specify run commands both on the mainturbocommand and therunsubcommand.Testing Instructions
Added unit tests for detection and an integration test to show the error message.