only add import references when they are used #8874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skips import to modules that are side effect free and have no exports referenced
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
arlyon
approved these changes
Jul 30, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 30, 2024
### Description
skips import to modules that are side effect free and have no exports
referenced
This allows to e. g. skip the `package` import completely in the
following code:
``` js
import { something } from "package"; // package is marked as side effect free
if (falsy) {
something();
}
```
This could happen e. g. with code like `if(process.env.NODE_ENV ===
"production")`
### Testing Instructions
<!--
Give a quick description of steps to test your changes.
-->
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
* vercel/turborepo#8875 <!-- Tobias Koppers - improve test glob to exclude output folder --> * vercel/turborepo#8874 <!-- Tobias Koppers - only add import references when they are used --> * vercel/turborepo#8766 <!-- Niklas Mischkulnig - Replace MDX ModuleType with MDX SourceTransform --> * vercel/turborepo#8090 <!-- DevMirza - fix(ci): Trying to fix `benchmark-turbopack` workflow --> * vercel/turborepo#8837 <!-- Niklas Mischkulnig - Make JS Lints have lower severity -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description
skips import to modules that are side effect free and have no exports
referenced
This allows to e. g. skip the `package` import completely in the
following code:
``` js
import { something } from "package"; // package is marked as side effect free
if (falsy) {
something();
}
```
This could happen e. g. with code like `if(process.env.NODE_ENV ===
"production")`
### Testing Instructions
<!--
Give a quick description of steps to test your changes.
-->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8875 <!-- Tobias Koppers - improve test glob to exclude output folder --> * vercel/turborepo#8874 <!-- Tobias Koppers - only add import references when they are used --> * vercel/turborepo#8766 <!-- Niklas Mischkulnig - Replace MDX ModuleType with MDX SourceTransform --> * vercel/turborepo#8090 <!-- DevMirza - fix(ci): Trying to fix `benchmark-turbopack` workflow --> * vercel/turborepo#8837 <!-- Niklas Mischkulnig - Make JS Lints have lower severity -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skips import to modules that are side effect free and have no exports referenced
This allows to e. g. skip the
packageimport completely in the following code:This could happen e. g. with code like
if(process.env.NODE_ENV === "production")Testing Instructions