Implement remainder of local Vcs: casting and get_task_id #8871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This was referenced Jul 30, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bgw
changed the title
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
|
Moved to the next.js repo: vercel/next.js#68474 |
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Aug 5, 2024
…#68474) *This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8871 ## Description With these changes, local Vcs (introduced in #68469) should have a fully functional implementation. These remaining methods were pretty straightforward. After this, my focus will shift back towards the changes needed to tasks to allow us to make use of local Vcs. ## New `resolve_type_inner` helper method I merged the implementations of `resolve_trait` and `resolve_value`, since their implementations were 95% identical. I think this is an overall win, though the logic to prevent duplicate `ValueType` lookups (they're not expensive, but this code is also potentially very hot) is a bit messy. ## Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
…#68474) *This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8871 ## Description With these changes, local Vcs (introduced in #68469) should have a fully functional implementation. These remaining methods were pretty straightforward. After this, my focus will shift back towards the changes needed to tasks to allow us to make use of local Vcs. ## New `resolve_type_inner` helper method I merged the implementations of `resolve_trait` and `resolve_value`, since their implementations were 95% identical. I think this is an overall win, though the logic to prevent duplicate `ValueType` lookups (they're not expensive, but this code is also potentially very hot) is a bit messy. ## Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
…#68474) *This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8871 ## Description With these changes, local Vcs (introduced in #68469) should have a fully functional implementation. These remaining methods were pretty straightforward. After this, my focus will shift back towards the changes needed to tasks to allow us to make use of local Vcs. ## New `resolve_type_inner` helper method I merged the implementations of `resolve_trait` and `resolve_value`, since their implementations were 95% identical. I think this is an overall win, though the logic to prevent duplicate `ValueType` lookups (they're not expensive, but this code is also potentially very hot) is a bit messy. ## Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
…#68474) *This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8871 ## Description With these changes, local Vcs (introduced in #68469) should have a fully functional implementation. These remaining methods were pretty straightforward. After this, my focus will shift back towards the changes needed to tasks to allow us to make use of local Vcs. ## New `resolve_type_inner` helper method I merged the implementations of `resolve_trait` and `resolve_value`, since their implementations were 95% identical. I think this is an overall win, though the logic to prevent duplicate `ValueType` lookups (they're not expensive, but this code is also potentially very hot) is a bit messy. ## Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With these changes, local Vcs (introduced in #8780) should have a fully functional implementation.
These remaining methods were pretty straightforward.
After this, my focus will shift back towards the changes needed to tasks to allow us to make use of local Vcs.
New
resolve_type_innerhelper methodI merged the implementations of
resolve_traitandresolve_value, since their implementations were 95% identical. I think this is an overall win, though the logic to prevent duplicateValueTypelookups (they're not expensive, but this code is also potentially very hot) is a bit messy.Testing Instructions