Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: Enable tree shaking in next.js" #8782

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Revert "feat: Enable tree shaking in next.js" #8782

merged 1 commit into from
Jul 18, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 18, 2024

Reverts #8755

@sokra sokra requested review from a team as code owners July 18, 2024 06:16
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 6:18am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 6:18am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-native-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-svelte-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am
examples-vite-web ⬜️ Ignored (Inspect) Jul 18, 2024 6:18am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@sokra sokra merged commit 2ad0240 into main Jul 18, 2024
52 of 54 checks passed
@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-core/src/util.rs:40:10: �[38;5;9merror[E0277]: the trait bound `PathType: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/app_structure.rs:104:10: �[38;5;9merror[E0277]: the trait bound `MetadataItem: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/app_structure.rs:477:10: �[38;5;9merror[E0277]: the trait bound `Entrypoint: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/util.rs:47:1: �[38;5;9merror[E0277]: the trait bound `PathType: Serialize` is not satisfied
packages/next-swc/crates/next-core/src/util.rs:47:1: �[38;5;9merror[E0277]: the trait bound `PathType: Deserialize<'_>` is not satisfied
packages/next-swc/crates/next-core/src/next_app/metadata/route.rs:33:1: �[38;5;9merror[E0277]: the trait bound `MetadataItem: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/app_structure.rs:475:89: �[38;5;9merror[E0277]: the trait bound `MetadataItem: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/next_app/metadata/route.rs:56:1: �[38;5;9merror[E0277]: the trait bound `MetadataItem: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/app_structure.rs:109:1: �[38;5;9merror[E0277]: the trait bound `MetadataItem: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/next_client/context.rs:133:13: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_client/context.rs:134:11: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_client/context.rs:133:13: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_client/context.rs:134:11: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/util.rs:47:1: �[38;5;9merror[E0277]: the trait bound `PathType: std::hash::Hash` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:85:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:88:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:91:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:94:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:97:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:98:9: �[38;5;9merror[E0277]: can't compare `Vc<turbo_tasks::RcStr>` with `Vc<turbo_tasks::RcStr>`
packages/next-swc/crates/next-core/src/next_server/context.rs:99:9: �[38;5;9merror[E0277]: can't compare `Vc<Box<dyn Transition>>` with `Vc<Box<dyn Transition>>`
packages/next-swc/crates/next-core/src/next_server/context.rs:102:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:103:9: �[38;5;9merror[E0277]: can't compare `Vc<turbo_tasks::RcStr>` with `Vc<turbo_tasks::RcStr>`
packages/next-swc/crates/next-core/src/next_server/context.rs:106:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:107:9: �[38;5;9merror[E0277]: can't compare `Vc<turbo_tasks::RcStr>` with `Vc<turbo_tasks::RcStr>`
packages/next-swc/crates/next-core/src/next_server/context.rs:110:9: �[38;5;9merror[E0277]: can't compare `Vc<FileSystemPath>` with `Vc<FileSystemPath>`
packages/next-swc/crates/next-core/src/next_server/context.rs:111:9: �[38;5;9merror[E0277]: can't compare `Vc<turbo_tasks::RcStr>` with `Vc<turbo_tasks::RcStr>`
packages/next-swc/crates/next-core/src/next_server/context.rs:85:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:88:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:91:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:94:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:97:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:98:9: �[38;5;9merror[E0277]: the trait bound `Vc<turbo_tasks::RcStr>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:99:9: �[38;5;9merror[E0277]: the trait bound `Vc<Box<dyn Transition>>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:102:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:103:9: �[38;5;9merror[E0277]: the trait bound `Vc<turbo_tasks::RcStr>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:106:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:107:9: �[38;5;9merror[E0277]: the trait bound `Vc<turbo_tasks::RcStr>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:110:9: �[38;5;9merror[E0277]: the trait bound `Vc<FileSystemPath>: Ord` is not satisfied
packages/next-swc/crates/next-core/src/next_server/context.rs:111:9: �[38;5;9merror[E0277]: the trait bound `Vc<turbo_tasks::RcStr>: Ord` is not satisfied
error: could not compile `next-core` (lib) due to 42 previous errors

See job summary for details

@sokra sokra deleted the revert-8755-kdy1/tree-shake branch July 18, 2024 06:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8782)
efb78ae 
Reverts vercel/turborepo#8755
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8782)
422d969 
Reverts vercel/turborepo#8755
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8782)
bb32bf1 
Reverts vercel/turborepo#8755
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8782)
52fa282 
Reverts vercel/turborepo#8755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@codybrouwers codybrouwers Awaiting requested review from codybrouwers codybrouwers is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @kdy1