Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ConcreteTaskInput in favor of the original rust datatypes #8737

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 12, 2024

Description

Instead of the ConcreteTaskInput conversion, we use a boxed any. This allows to store arguments in plain rust structures and uses less memory.

We need to do some magic to make serialization possible.

Also removed Ord requirement from TaskInputs and make Vc not implement Ord

Testing Instructions

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 0:23am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 0:23am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:23am

Copy link
Member Author

sokra commented Jul 12, 2024

Copy link
Contributor

github-actions bot commented Jul 12, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jul 12, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

✅ This change can build next-swc

@sokra sokra marked this pull request as ready for review July 12, 2024 13:30
@sokra sokra requested a review from a team as a code owner July 12, 2024 13:30
@sokra sokra requested a review from bgw July 12, 2024 14:04
@sokra sokra mentioned this pull request Jul 16, 2024
@sokra sokra merged commit 0e3d994 into main Jul 18, 2024
52 of 54 checks passed
@sokra sokra deleted the sokra/improve-task-input branch July 18, 2024 00:35
bgw pushed a commit to vercel/next.js that referenced this pull request Jul 18, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…cel/turborepo#8737)

### Description

Instead of the ConcreteTaskInput conversion, we use a boxed any. This
allows to store arguments in plain rust structures and uses less memory.

We need to do some magic to make serialization possible.

Also removed Ord requirement from TaskInputs and make Vc not implement
Ord

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…cel/turborepo#8737)

### Description

Instead of the ConcreteTaskInput conversion, we use a boxed any. This
allows to store arguments in plain rust structures and uses less memory.

We need to do some magic to make serialization possible.

Also removed Ord requirement from TaskInputs and make Vc not implement
Ord

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…cel/turborepo#8737)

### Description

Instead of the ConcreteTaskInput conversion, we use a boxed any. This
allows to store arguments in plain rust structures and uses less memory.

We need to do some magic to make serialization possible.

Also removed Ord requirement from TaskInputs and make Vc not implement
Ord

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…cel/turborepo#8737)

### Description

Instead of the ConcreteTaskInput conversion, we use a boxed any. This
allows to store arguments in plain rust structures and uses less memory.

We need to do some magic to make serialization possible.

Also removed Ord requirement from TaskInputs and make Vc not implement
Ord

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants