Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rimraf to native #8729

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

torresgol10
Copy link
Contributor

@torresgol10 torresgol10 commented Jul 11, 2024

We remove the dependency on rimraf and replace it with native, keeping the functionality in packages/create-turbo and packages/turbo-test-utils

@torresgol10 torresgol10 requested review from a team as code owners July 11, 2024 22:54
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo owned-by: turbopack pkg: create-turbo Issues related to npx create-turbo labels Jul 11, 2024
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:13pm

Copy link

vercel bot commented Jul 11, 2024

@torresgol10 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jul 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 31addf6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@anthonyshew
Copy link
Contributor

Looks like some failures in the JS package tests: https://github.com/vercel/turbo/actions/runs/9901744124/job/27354620086?pr=8729

@torresgol10
Copy link
Contributor Author

@anthonyshew I forgot to pass you the parameters for the recursion deletion, sorry.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Looks good to go now. Thank you once again!

@anthonyshew anthonyshew merged commit 7f3162f into vercel:main Jul 23, 2024
66 of 68 checks passed
@torresgol10 torresgol10 deleted the replace-rimraf-native branch July 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turbopack owned-by: turborepo pkg: create-turbo Issues related to npx create-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants