fix(turbopack-ecmascript-runtime): prevent hanging when top level await is skipped #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
ForsakenHarmony
commented
Jun 10, 2024
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
|
arlyon
approved these changes
Jun 11, 2024
ForsakenHarmony
force-pushed
the
hrmny/pack-3039-top-level-await-hanging
branch
from
81edb44
to
959442e
Compare
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Jun 14, 2024
This was previously disabled on `aarch64-unknown-linux-musl` and `wasm`,
due to compilation errors.
I moved the logic to disable `mimalloc` on these platforms into the
`turbo-tasks-malloc` crates in vercel/turborepo#8462
(which this PR depends on).
In addition to centralizing mimalloc platform support logic, this means
that we can get allocation data from these platforms while using the
system allocator.
**Depends on:** vercel/turborepo#8462
Included turbopack changes:
* vercel/turborepo#8409 <!-- hrmny -
fix(turbopack-ecmascript-runtime): prevent hanging when top level await
is skipped -->
* vercel/turborepo#8466 <!-- hrmny - fix(turbopack):
make external module wrapper return not found instead of panicking -->
* vercel/turborepo#8469 <!-- hrmny - fix(turbopack):
add ecmascript options to mdx -->
* vercel/turborepo#8447 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.93.4` -->
* vercel/turborepo#8472 <!-- Donny/강동윤 - feat:
Reduce the number of parts created by tree shaking -->
* vercel/turborepo#8480 <!-- Will Binns-Smith -
Publish `@vercel/devlow-bench` -->
* vercel/turborepo#8481 <!-- Will Binns-Smith -
chore: release npm packages -->
* vercel/turborepo#8462 <!-- Benjamin Woodruff -
Update mimalloc, enable for glibc Linux aarch64, explicitly disable for
wasm and musl -->
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…it is skipped (vercel/turborepo#8409) ### Description A "race condition" was causing the queue to never be resolved. ### Testing Instructions Added a new test for it Fixes #65278
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…it is skipped (vercel/turborepo#8409) ### Description A "race condition" was causing the queue to never be resolved. ### Testing Instructions Added a new test for it Fixes #65278
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…it is skipped (vercel/turborepo#8409) ### Description A "race condition" was causing the queue to never be resolved. ### Testing Instructions Added a new test for it Fixes #65278
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…it is skipped (vercel/turborepo#8409) ### Description A "race condition" was causing the queue to never be resolved. ### Testing Instructions Added a new test for it Fixes #65278
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
This was previously disabled on `aarch64-unknown-linux-musl` and `wasm`,
due to compilation errors.
I moved the logic to disable `mimalloc` on these platforms into the
`turbo-tasks-malloc` crates in vercel/turborepo#8462
(which this PR depends on).
In addition to centralizing mimalloc platform support logic, this means
that we can get allocation data from these platforms while using the
system allocator.
**Depends on:** vercel/turborepo#8462
Included turbopack changes:
* vercel/turborepo#8409 <!-- hrmny -
fix(turbopack-ecmascript-runtime): prevent hanging when top level await
is skipped -->
* vercel/turborepo#8466 <!-- hrmny - fix(turbopack):
make external module wrapper return not found instead of panicking -->
* vercel/turborepo#8469 <!-- hrmny - fix(turbopack):
add ecmascript options to mdx -->
* vercel/turborepo#8447 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.93.4` -->
* vercel/turborepo#8472 <!-- Donny/강동윤 - feat:
Reduce the number of parts created by tree shaking -->
* vercel/turborepo#8480 <!-- Will Binns-Smith -
Publish `@vercel/devlow-bench` -->
* vercel/turborepo#8481 <!-- Will Binns-Smith -
chore: release npm packages -->
* vercel/turborepo#8462 <!-- Benjamin Woodruff -
Update mimalloc, enable for glibc Linux aarch64, explicitly disable for
wasm and musl -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
This was previously disabled on `aarch64-unknown-linux-musl` and `wasm`,
due to compilation errors.
I moved the logic to disable `mimalloc` on these platforms into the
`turbo-tasks-malloc` crates in vercel/turborepo#8462
(which this PR depends on).
In addition to centralizing mimalloc platform support logic, this means
that we can get allocation data from these platforms while using the
system allocator.
**Depends on:** vercel/turborepo#8462
Included turbopack changes:
* vercel/turborepo#8409 <!-- hrmny -
fix(turbopack-ecmascript-runtime): prevent hanging when top level await
is skipped -->
* vercel/turborepo#8466 <!-- hrmny - fix(turbopack):
make external module wrapper return not found instead of panicking -->
* vercel/turborepo#8469 <!-- hrmny - fix(turbopack):
add ecmascript options to mdx -->
* vercel/turborepo#8447 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.93.4` -->
* vercel/turborepo#8472 <!-- Donny/강동윤 - feat:
Reduce the number of parts created by tree shaking -->
* vercel/turborepo#8480 <!-- Will Binns-Smith -
Publish `@vercel/devlow-bench` -->
* vercel/turborepo#8481 <!-- Will Binns-Smith -
chore: release npm packages -->
* vercel/turborepo#8462 <!-- Benjamin Woodruff -
Update mimalloc, enable for glibc Linux aarch64, explicitly disable for
wasm and musl -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
This was previously disabled on `aarch64-unknown-linux-musl` and `wasm`,
due to compilation errors.
I moved the logic to disable `mimalloc` on these platforms into the
`turbo-tasks-malloc` crates in vercel/turborepo#8462
(which this PR depends on).
In addition to centralizing mimalloc platform support logic, this means
that we can get allocation data from these platforms while using the
system allocator.
**Depends on:** vercel/turborepo#8462
Included turbopack changes:
* vercel/turborepo#8409 <!-- hrmny -
fix(turbopack-ecmascript-runtime): prevent hanging when top level await
is skipped -->
* vercel/turborepo#8466 <!-- hrmny - fix(turbopack):
make external module wrapper return not found instead of panicking -->
* vercel/turborepo#8469 <!-- hrmny - fix(turbopack):
add ecmascript options to mdx -->
* vercel/turborepo#8447 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.93.4` -->
* vercel/turborepo#8472 <!-- Donny/강동윤 - feat:
Reduce the number of parts created by tree shaking -->
* vercel/turborepo#8480 <!-- Will Binns-Smith -
Publish `@vercel/devlow-bench` -->
* vercel/turborepo#8481 <!-- Will Binns-Smith -
chore: release npm packages -->
* vercel/turborepo#8462 <!-- Benjamin Woodruff -
Update mimalloc, enable for glibc Linux aarch64, explicitly disable for
wasm and musl -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A "race condition" was causing the queue to never be resolved.
Testing Instructions
Added a new test for it
Fixes vercel/next.js#65278