Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeforeResolvePluginCondition: allow module filtering as a condition for BeforeResolvePlugins #8407

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wbinnssmith
Copy link
Member

This expands BeforeResolvePluginCondition to match on individual modules rather than just the request string.

Needed for vercel/next.js#66622

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:50pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:50pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:50pm

Copy link
Contributor

github-actions bot commented Jun 10, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 10, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 10, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

…or `BeforeResolvePlugin`s

This expands `BeforeResolvePluginCondition` to match on individual modules rather than just the request string.

Needed for vercel/next.js#66622
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/before-resolve-module branch from 71787a9 to d23d385 Compare June 12, 2024 18:48
Copy link
Member Author

wbinnssmith commented Jun 12, 2024

@sokra sokra merged commit c7e0063 into main Jun 12, 2024
56 of 58 checks passed
@sokra sokra deleted the wbinnssmith/before-resolve-module branch June 12, 2024 20:08
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…or `BeforeResolvePlugin`s (vercel/turborepo#8407)

This expands `BeforeResolvePluginCondition` to match on individual
modules rather than just the request string.

Needed for #66622
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…or `BeforeResolvePlugin`s (vercel/turborepo#8407)

This expands `BeforeResolvePluginCondition` to match on individual
modules rather than just the request string.

Needed for #66622
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…or `BeforeResolvePlugin`s (vercel/turborepo#8407)

This expands `BeforeResolvePluginCondition` to match on individual
modules rather than just the request string.

Needed for #66622
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…or `BeforeResolvePlugin`s (vercel/turborepo#8407)

This expands `BeforeResolvePluginCondition` to match on individual
modules rather than just the request string.

Needed for #66622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants