Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename runtime/none to runtime/edge #8397

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jun 10, 2024

Description

Further renaming building on top of the earlier PRs in the stack.

Testing Instructions

@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turbopack labels Jun 10, 2024
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:24am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:24am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:24am

Copy link
Member Author

timneutkens commented Jun 10, 2024

Copy link
Contributor

github-actions bot commented Jun 10, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 10, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 10, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member Author

timneutkens commented Jun 19, 2024

Merge activity

  • Jun 19, 4:21 AM EDT: @timneutkens started a stack merge that includes this pull request via Graphite.
  • Jun 19, 4:22 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 19, 4:30 AM EDT: @timneutkens merged this pull request with Graphite.

Base automatically changed from 06-10-rename_dev_runtime_to_browser_runtime to main June 19, 2024 08:21
@timneutkens timneutkens force-pushed the 06-10-rename_runtime_none_to_runtime_edge branch from 6803dbe to 2f21896 Compare June 19, 2024 08:22
@timneutkens timneutkens merged commit 0e71e12 into main Jun 19, 2024
53 of 54 checks passed
@timneutkens timneutkens deleted the 06-10-rename_runtime_none_to_runtime_edge branch June 19, 2024 08:30
sokra pushed a commit to vercel/next.js that referenced this pull request Jun 20, 2024
Upgrades Turbopack

* vercel/turborepo#8421 <!-- Tim Neutkens - Fix
Turbopack benchmark for next@canary -->
* vercel/turborepo#8396 <!-- Tim Neutkens - Rename
dev_runtime to browser_runtime -->
* vercel/turborepo#8397 <!-- Tim Neutkens - Rename
runtime/none to runtime/edge -->
* vercel/turborepo#8398 <!-- Tim Neutkens - Remove
unused Node.js runtime -->
* vercel/turborepo#8399 <!-- Tim Neutkens - Rename
build runtime to nodejs -->
* vercel/turborepo#8400 <!-- Tim Neutkens - Rename
dev runtime to browser -->

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Further renaming building on top of the earlier PRs in the stack.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Further renaming building on top of the earlier PRs in the stack.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Further renaming building on top of the earlier PRs in the stack.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Further renaming building on top of the earlier PRs in the stack.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
Upgrades Turbopack

* vercel/turborepo#8421 <!-- Tim Neutkens - Fix
Turbopack benchmark for next@canary -->
* vercel/turborepo#8396 <!-- Tim Neutkens - Rename
dev_runtime to browser_runtime -->
* vercel/turborepo#8397 <!-- Tim Neutkens - Rename
runtime/none to runtime/edge -->
* vercel/turborepo#8398 <!-- Tim Neutkens - Remove
unused Node.js runtime -->
* vercel/turborepo#8399 <!-- Tim Neutkens - Rename
build runtime to nodejs -->
* vercel/turborepo#8400 <!-- Tim Neutkens - Rename
dev runtime to browser -->

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turbopack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants