Replace chalk by picocolors #8390
Conversation
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
removed
the
needs: triage
turbo-orchestrator
bot
added
the
needs: triage
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Awesome! Will help my npx create-turbo that much quicker.
Going through each package to visually check behavior:
- turbo-workspaces
- turbo-telemetry
- turbo-gen - Won't build but I can't quite tell why. ESM vs CJS?
- turbo-codemod - Won't build but I can't quite tell why. ESM vs CJS?
-
create-turbo
Seems like it has to do with the implementation of hex.
|
@anthonyshew Sorry, I had a bug in the implementation so it didn't paint lines it shouldn't, also change the
About the |
|
Thanks! Updated list:
Once those are buildable again, I'll give them a look. |
|
@anthonyshew I'm sorry, I've been looking at the reason for the fault and I've managed to find out where it comes from but I can't find out why it's wrong, I don't know if you could help me. The bug is in the
|
|
No worries! I think this is the dreaded ESM/CJS error. I'll do my best to find time to take a look at this when I can. |
|
@anthonyshew I have made a few changes and it compiles perfectly. 🎉 I have removed the If the colour change is not a problem (it is a "similar" colour) I think you can continue with the tests. Thank you very much. |
|
@torresgol10, it looks like there are a few more references to do away with: https://github.com/vercel/turbo/actions/runs/9897583783/job/27342448642?pr=8390 The ones in Once we have those cleared up, we should be good to go! |
torresgol10
force-pushed
the
replace-chalk-by-picocolors
branch
from
0778edf
to
f9723b3
Compare
|
@anthonyshew It's OK, it's normal to have to make changes, everything would be solved and the conflicts would be solved. Thank you very much and I would love to continue making small changes to this great project. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@types/[email protected] |
|
@anthonyshew I don't know if I did it right, but I saw an error in the "Formating" and I fixed it by making a new commit. |
We replaced chalk with picocolors as it is much more optimal and smaller. Discussions: vercel/turborepo#8341 In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR. I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used. Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment. I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export. 1. The implementation does not use the ‘bits’ because typescript gives error, if you see it necessary I can change the implementation. 2. I don't know if this is the right place to put this function, do you think it's necessary to create a test? --------- Co-authored-by: torresgol10.itd <[email protected]> Co-authored-by: Anthony Shew <[email protected]>
We replaced chalk with picocolors as it is much more optimal and smaller. Discussions: vercel/turborepo#8341 In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR. I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used. Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment. I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export. 1. The implementation does not use the ‘bits’ because typescript gives error, if you see it necessary I can change the implementation. 2. I don't know if this is the right place to put this function, do you think it's necessary to create a test? --------- Co-authored-by: torresgol10.itd <[email protected]> Co-authored-by: Anthony Shew <[email protected]>
We replaced chalk with picocolors as it is much more optimal and smaller. Discussions: vercel/turborepo#8341 In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR. I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used. Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment. I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export. 1. The implementation does not use the ‘bits’ because typescript gives error, if you see it necessary I can change the implementation. 2. I don't know if this is the right place to put this function, do you think it's necessary to create a test? --------- Co-authored-by: torresgol10.itd <[email protected]> Co-authored-by: Anthony Shew <[email protected]>
We replaced chalk with picocolors as it is much more optimal and smaller. Discussions: vercel/turborepo#8341 In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR. I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used. Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment. I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export. 1. The implementation does not use the ‘bits’ because typescript gives error, if you see it necessary I can change the implementation. 2. I don't know if this is the right place to put this function, do you think it's necessary to create a test? --------- Co-authored-by: torresgol10.itd <[email protected]> Co-authored-by: Anthony Shew <[email protected]>
We replaced chalk with picocolors as it is much more optimal and smaller.
Discussions: #8341
In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR.
I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used.
Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment.
I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export.