Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ChunkLoading::None to ChunkLoading::Edge #8376

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jun 7, 2024

Description

Changing the name in order to reflect reality after talking to @sokra.

Testing Instructions

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:09pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:09pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 2:09pm

@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turbopack labels Jun 7, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented Jun 7, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 7, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 52d3aa9 into main Jun 7, 2024
56 of 58 checks passed
@sokra sokra deleted the 06-07-rename_chunkloading_none_to_chunkloading_edge branch June 7, 2024 21:42
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jun 10, 2024
### What?
This is a fix for a bundle potentially referring to two different
external modules (e.g. `react` because it gets invalided from the
require cache)

See vercel/turborepo#7988

### Turbopack Updates
* vercel/turborepo#8376 <!-- Tim Neutkens - Rename
ChunkLoading::None to ChunkLoading::Edge -->
* vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add
an execution test for `paren_remover` -->
* vercel/turborepo#8370 <!-- Tobias Koppers - Tree
Shaking shared state and side effects -->
* vercel/turborepo#7988 <!-- hrmny -
feat(turbopack-ecmascript): cache external modules with wrapper -->

Closes PACK-2622
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Changing the name in order to reflect reality after talking to @sokra.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Changing the name in order to reflect reality after talking to @sokra.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Changing the name in order to reflect reality after talking to @sokra.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Changing the name in order to reflect reality after talking to @sokra.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 16, 2024
This is a fix for a bundle potentially referring to two different
external modules (e.g. `react` because it gets invalided from the
require cache)

See vercel/turborepo#7988

* vercel/turborepo#8376 <!-- Tim Neutkens - Rename
ChunkLoading::None to ChunkLoading::Edge -->
* vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add
an execution test for `paren_remover` -->
* vercel/turborepo#8370 <!-- Tobias Koppers - Tree
Shaking shared state and side effects -->
* vercel/turborepo#7988 <!-- hrmny -
feat(turbopack-ecmascript): cache external modules with wrapper -->

Closes PACK-2622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turbopack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants