-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ChunkLoading::None to ChunkLoading::Edge #8376
Merged
sokra
merged 2 commits into
main
from
06-07-rename_chunkloading_none_to_chunkloading_edge
Jun 7, 2024
Merged
Rename ChunkLoading::None to ChunkLoading::Edge #8376
sokra
merged 2 commits into
main
from
06-07-rename_chunkloading_none_to_chunkloading_edge
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
turbo-orchestrator
bot
added
needs: triage
New issues get this label. Remove it after triage
owned-by: turbopack
labels
Jun 7, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
sokra
approved these changes
Jun 7, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jun 10, 2024
### What? This is a fix for a bundle potentially referring to two different external modules (e.g. `react` because it gets invalided from the require cache) See vercel/turborepo#7988 ### Turbopack Updates * vercel/turborepo#8376 <!-- Tim Neutkens - Rename ChunkLoading::None to ChunkLoading::Edge --> * vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add an execution test for `paren_remover` --> * vercel/turborepo#8370 <!-- Tobias Koppers - Tree Shaking shared state and side effects --> * vercel/turborepo#7988 <!-- hrmny - feat(turbopack-ecmascript): cache external modules with wrapper --> Closes PACK-2622
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Changing the name in order to reflect reality after talking to @sokra. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Changing the name in order to reflect reality after talking to @sokra. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Changing the name in order to reflect reality after talking to @sokra. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Changing the name in order to reflect reality after talking to @sokra. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
This is a fix for a bundle potentially referring to two different external modules (e.g. `react` because it gets invalided from the require cache) See vercel/turborepo#7988 * vercel/turborepo#8376 <!-- Tim Neutkens - Rename ChunkLoading::None to ChunkLoading::Edge --> * vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add an execution test for `paren_remover` --> * vercel/turborepo#8370 <!-- Tobias Koppers - Tree Shaking shared state and side effects --> * vercel/turborepo#7988 <!-- hrmny - feat(turbopack-ecmascript): cache external modules with wrapper --> Closes PACK-2622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the name in order to reflect reality after talking to @sokra.
Testing Instructions