-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small tree shaking fix and test case update #8347
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
## Item 3: Stmt 2, `Normal` | ||
|
||
```js | ||
export { dog as DOG, cat }; | ||
|
||
``` | ||
|
||
- Side effects | ||
- Reads: `dog`, `cat` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdy1 The whole statement is pretty wrong.
It should not have side effects. It should not read vars. It shouldn't exist at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if it does not exist, dependency graph will be wrong I think
## Part 1 | ||
```js | ||
export { DOG as DOG }; | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdy1 This looks weird. It should import dog
shouldn't it?
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
Description
avoid adding module evaluation to internal part imports
add a broken test case
update split-chunk test case to work and be more clear
Testing Instructions