Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused base16 dependency and dead hex wrapper function #8207

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: Remove unused base16 dependency and dead hex wrapper function #8207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd815e
chore: Remove unused base16 dependency
bgw May 23, 2024
017a9b7
Also remove dead `encode_hex_string` function and remove entries from…
bgw May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions crates/turbo-tasks-hash/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ bench = false
workspace = true

[dependencies]
base16 = "0.2.1"
hex = "0.4.3"
md4 = "0.10.1"
turbo-tasks-macros = { workspace = true }
twox-hash = "1.6.3"
4 changes: 0 additions & 4 deletions crates/turbo-tasks-hash/src/base16.rs
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions crates/turbo-tasks-hash/src/hex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,3 @@
pub fn encode_hex(n: u64) -> String {
format!("{:01$x}", n, std::mem::size_of::<u64>() * 2)
}

/// Encodes a byte slice into a hex string.
pub fn encode_hex_string(bytes: &[u8]) -> String {
hex::encode(bytes)
}
4 changes: 1 addition & 3 deletions crates/turbo-tasks-hash/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,14 @@
//! invalidation, and encoding the hash to an hexadecimal string for use in a
//! file name.

mod base16;
mod deterministic_hash;
mod hex;
mod md4;
mod xxh3_hash64;

pub use crate::{
base16::encode_base16,
deterministic_hash::{DeterministicHash, DeterministicHasher},
hex::{encode_hex, encode_hex_string},
hex::encode_hex,
md4::hash_md4,
xxh3_hash64::{hash_xxh3_hash64, Xxh3Hash64Hasher},
};
2 changes: 1 addition & 1 deletion deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ allow = [
"MPL-2.0-no-copyleft-exception",
# enum-iterator*
"0BSD",
# base16, notify
# notify
"CC0-1.0",
# Inflector, hyper-tungstenite
"BSD-2-Clause",
Expand Down
Loading