-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove globalDotEnv
and dotEnv
fields
#8181
Merged
chris-olszewski
merged 4 commits into
turborepo_2
from
chrisolszewski/turbo-3124-remove-dotenv
May 21, 2024
Merged
chore: remove globalDotEnv
and dotEnv
fields
#8181
chris-olszewski
merged 4 commits into
turborepo_2
from
chrisolszewski/turbo-3124-remove-dotenv
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
requested review from
tknickman,
padmaia and
a team
as code owners
May 20, 2024 23:56
🟢 CI successful 🟢Thanks |
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3124-remove-dotenv
branch
from
May 21, 2024 05:27
c65090c
to
0d2ed5d
Compare
mehulkar
approved these changes
May 21, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies` and `inputs` which is now fairly ergonomic to use with the addition of `$TURBO_DEFAULTS$`. This PR does *not* update the corresponding JS types. ### Testing Instructions Updated existing integration tests
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies` and `inputs` which is now fairly ergonomic to use with the addition of `$TURBO_DEFAULTS$`. This PR does *not* update the corresponding JS types. ### Testing Instructions Updated existing integration tests
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies` and `inputs` which is now fairly ergonomic to use with the addition of `$TURBO_DEFAULTS$`. This PR does *not* update the corresponding JS types. Updated existing integration tests
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies` and `inputs` which is now fairly ergonomic to use with the addition of `$TURBO_DEFAULTS$`. This PR does *not* update the corresponding JS types. Updated existing integration tests
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies` and `inputs` which is now fairly ergonomic to use with the addition of `$TURBO_DEFAULTS$`. This PR does *not* update the corresponding JS types. Updated existing integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
globalDotEnv
/dotEnv
in favor ofglobalDependencies
andinputs
which is now fairly ergonomic to use with the addition of$TURBO_DEFAULTS$
.This PR does not update the corresponding JS types.
Testing Instructions
Updated existing integration tests