-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): breakup GH test.yml #8027
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Logs
See job summary for details |
|
turbopack and turborepo tests are often blocking each other and there is no good reason to keep them all in one workflow. This PR separates them. Since linting and JS packages are not cleanly separated between the projects, they get their own workflows as well
85941b8
to
987fe97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this solve the required checks issue that caused us to merge these into one action last time?
I think the required check thing is handled by the "Determine Jobs" job in each one. IIUC, any job that is a required check and only runs on some paths needs this handling. All the broken up workflows are duplicating that logic, so there's a final |
turbopack and turborepo tests are often blocking each other and
there is no good reason to keep them all in one workflow. This
PR separates them. Since linting and JS packages are not cleanly
separated between the projects, they get their own workflows as well
Closes TURBO-2868