Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbopack-ecmascript): cache external modules with wrapper #7988

Merged
merged 7 commits into from
Jun 10, 2024
Merged

feat(turbopack-ecmascript): cache external modules with wrapper #7988

merged 7 commits into from
Jun 10, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

Description

New attempt at adding this after reverting 🙃

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 2:09pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 2:09pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Jun 10, 2024 2:09pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:09pm

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 16, 2024 0:32am
rust-docs 🔄 Building (Inspect) Visit Preview Apr 16, 2024 0:32am
8 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-native-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am
examples-vite-web ⬜️ Ignored (Inspect) Apr 16, 2024 0:32am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from ba5e20a to 03aa0ca Compare April 16, 2024 18:56
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 03aa0ca to 47b73f5 Compare April 17, 2024 16:21
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 47b73f5 to 0f1b8c6 Compare April 19, 2024 17:21
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 0f1b8c6 to 8e33ac1 Compare April 19, 2024 17:32
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 8e33ac1 to 23a64a6 Compare April 22, 2024 13:08
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 64c6040 to 9613e68 Compare June 5, 2024 21:40
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 9613e68 to 61b9af3 Compare June 7, 2024 16:41
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 61b9af3 to be2e189 Compare June 10, 2024 13:59
@ForsakenHarmony ForsakenHarmony merged commit efcea76 into main Jun 10, 2024
58 of 60 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-2622-cache-external-modules-during-evaluation branch June 10, 2024 15:17
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jun 10, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (#63337)
6c1d700 
### What?
This is a fix for a bundle potentially referring to two different
external modules (e.g. `react` because it gets invalided from the
require cache)

See vercel/turborepo#7988

### Turbopack Updates
* vercel/turborepo#8376 <!-- Tim Neutkens - Rename
ChunkLoading::None to ChunkLoading::Edge -->
* vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add
an execution test for `paren_remover` -->
* vercel/turborepo#8370 <!-- Tobias Koppers - Tree
Shaking shared state and side effects -->
* vercel/turborepo#7988 <!-- hrmny -
feat(turbopack-ecmascript): cache external modules with wrapper -->

Closes PACK-2622
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
10a22fd 
…el/turborepo#7988)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
726d45e 
…el/turborepo#7988)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
b2edc67 
…el/turborepo#7988)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
5cd5c66 
…el/turborepo#7988)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (#63337)
b91ecdb 
This is a fix for a bundle potentially referring to two different
external modules (e.g. `react` because it gets invalided from the
require cache)

See vercel/turborepo#7988

* vercel/turborepo#8376 <!-- Tim Neutkens - Rename
ChunkLoading::None to ChunkLoading::Edge -->
* vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add
an execution test for `paren_remover` -->
* vercel/turborepo#8370 <!-- Tobias Koppers - Tree
Shaking shared state and side effects -->
* vercel/turborepo#7988 <!-- hrmny -
feat(turbopack-ecmascript): cache external modules with wrapper -->

Closes PACK-2622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForsakenHarmony @sokra @kdy1