Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change Itemstatus signature to include TimeSaved metric #5037

Closed
wants to merge 1 commit into from

Conversation

mehulkar
Copy link
Contributor

This is a pre-requisite to #4952. Things to test:

  • cache hit from fs works (integration tests should cover this)
  • remote cache hit works
  • both misses work
  • daemon skip cache check works
  • hits from local and remote works
  • hit from remote populates local cache
  • hit from local populates remote cache

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) May 19, 2023 11:21pm
examples-designsystem-docs 🔄 Building (Inspect) May 19, 2023 11:21pm
examples-nonmonorepo 🔄 Building (Inspect) May 19, 2023 11:21pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-native-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-svelte-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
examples-vite-web ⬜️ Ignored (Inspect) May 19, 2023 11:21pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 19, 2023 11:21pm

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

🟢 CI successful 🟢

Thanks

@mehulkar mehulkar closed this May 19, 2023
@mehulkar mehulkar deleted the mk/refactor-item-status branch May 19, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant