You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a side note... the only reason I ran into this is because I accidentally added a pnpm-gatsby example test in #4929. I'm going to delete that and we can take this PR back to draft. I imagine what we should do is add that test and resolve any issues like this as part of that.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, If I remember correctly one of the plugins we had on this example (possibly the pnpm one?) required 18 at the time (I definitely remember I added it for some reason haha). But the build looks good so
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that CI runs node 18, we can enable this test and see it pass.