Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(examples): enable gatsby example test in CI #4999

Merged
merged 1 commit into from
Jun 15, 2023
Merged

ci(examples): enable gatsby example test in CI #4999

merged 1 commit into from
Jun 15, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented May 17, 2023 •
edited
Loading

Now that CI runs node 18, we can enable this test and see it pass.

@mehulkar mehulkar requested a review from a team as a code owner May 17, 2023 16:32
@mehulkar mehulkar requested review from tknickman and arlyon May 17, 2023 16:32
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples team: turborepo labels May 17, 2023
@vercel
Copy link

vercel bot commented May 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:13am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 10:13am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 10:13am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 10:13am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 10:13am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 10:13am

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@mehulkar
Copy link
Contributor Author

On a side note... the only reason I ran into this is because I accidentally added a pnpm-gatsby example test in #4929. I'm going to delete that and we can take this PR back to draft. I imagine what we should do is add that test and resolve any issues like this as part of that.

@mehulkar mehulkar marked this pull request as draft May 17, 2023 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: none of the selected packages contains these features: __internal_nextjs_integration_test

See job summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Linux Benchmark for 663c48c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8654.84µs ± 47.48µs 8805.18µs ± 85.01µs +1.74%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7944.34µs ± 78.02µs 8028.07µs ± 109.62µs +1.05%
bench_startup/Turbopack CSR/1000 modules 930.24ms ± 3.03ms 933.37ms ± 10.18ms +0.34%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Windows Benchmark for 663c48c

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3253.70ms ± 8.05ms 3374.00ms ± 31.33ms +3.70% +1.27%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 18.37ms ± 2.12ms 15.62ms ± 0.03ms -14.94%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.56ms ± 0.02ms 15.51ms ± 0.01ms -0.31%
bench_startup/Turbopack CSR/1000 modules 3253.70ms ± 8.05ms 3374.00ms ± 31.33ms +3.70% +1.27%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

MacOS Benchmark for 663c48c

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 36.01ms ± 1.46ms 25.35ms ± 0.26ms -29.60% -21.82%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.69ms ± 0.21ms 30.73ms ± 1.66ms +24.49% +9.16%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 36.01ms ± 1.46ms 25.35ms ± 0.26ms -29.60% -21.82%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.69ms ± 0.21ms 30.73ms ± 1.66ms +24.49% +9.16%
bench_startup/Turbopack CSR/1000 modules 3234.13ms ± 21.80ms 3310.37ms ± 64.76ms +2.36%

tknickman
tknickman approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, If I remember correctly one of the plugins we had on this example (possibly the pnpm one?) required 18 at the time (I definitely remember I added it for some reason haha). But the build looks good so :shipit:

@turbo-orchestrator turbo-orchestrator bot removed the area: examples Improvements or additions to examples label Jun 15, 2023
@mehulkar mehulkar changed the title chore: make node version less strict for gatsby example ci(examples): enable gatsby example test in CI Jun 15, 2023
@mehulkar mehulkar marked this pull request as ready for review June 15, 2023 10:20
@mehulkar mehulkar requested a review from a team as a code owner June 15, 2023 10:20
@mehulkar mehulkar enabled auto-merge (squash) June 15, 2023 10:21
@github-actions
Copy link
Contributor

Linux Benchmark for e29d7d2

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 7390.81µs ± 35.30µs 7891.10µs ± 210.00µs +6.77% +0.13%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8272.87µs ± 46.92µs 8321.05µs ± 37.11µs +0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7390.81µs ± 35.30µs 7891.10µs ± 210.00µs +6.77% +0.13%
bench_startup/Turbopack CSR/1000 modules 909.94ms ± 3.26ms 902.08ms ± 5.12ms -0.86%

@mehulkar mehulkar merged commit d859a8b into main Jun 15, 2023
@mehulkar mehulkar deleted the mk/gatsby-node-version branch June 15, 2023 11:10
@github-actions
Copy link
Contributor

MacOS Benchmark for e29d7d2

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 34.30s ± 3.67s 8988.34ms ± 3643.79ms -73.80% -39.62%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.83ms ± 0.19ms 26.23ms ± 0.44ms -2.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules 23.08ms ± 0.25ms 26.41ms ± 2.23ms +14.45%
bench_startup/Turbopack CSR/1000 modules 34.30s ± 3.67s 8988.34ms ± 3643.79ms -73.80% -39.62%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehulkar @tknickman