Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include timeSaved metric when skipping cache check #4952

Merged
merged 22 commits into from
May 31, 2023
Merged

Include timeSaved metric when skipping cache check #4952

merged 22 commits into from
May 31, 2023

Commits on May 19, 2023

  1. refactor: Change Itemstatus signature to include TimeSaved metric

    Mehul Kar authored and Mehul Kar committed May 19, 2023
    Configuration menu
    Copy the full SHA
    f9f3e16 View commit details
    Browse the repository at this point in the history

  2. Improve log message when cache restoration is skipped

    @mehulkar
    mehulkar authored and Mehul Kar committed May 19, 2023
    Configuration menu
    Copy the full SHA
    57c05e0 View commit details
    Browse the repository at this point in the history

  3. Return timeSaved metric even when cache restoration is skipped

    @mehulkar
    mehulkar authored and Mehul Kar committed May 19, 2023
    Configuration menu
    Copy the full SHA
    01a4a6d View commit details
    Browse the repository at this point in the history

  4. Fix how Exists() works to make clear that its not composite, but firs… 

    …t one wins
    Mehul Kar authored and Mehul Kar committed May 19, 2023
    Configuration menu
    Copy the full SHA
    c39306c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Exit the loop early on a cache hit, since we're propaging a cache hit… 

    … to other caches
    Mehul Kar authored and Mehul Kar committed May 20, 2023
    Configuration menu
    Copy the full SHA
    b1dd3bc View commit details
    Browse the repository at this point in the history

  2. Check for a cahce hit after handling errors

    Mehul Kar authored and Mehul Kar committed May 20, 2023
    Configuration menu
    Copy the full SHA
    73674e8 View commit details
    Browse the repository at this point in the history

  3. extract duration extracter function instead of just a const

    Mehul Kar authored and Mehul Kar committed May 20, 2023
    Configuration menu
    Copy the full SHA
    92bb2a4 View commit details
    Browse the repository at this point in the history

  4. Make method private

    Mehul Kar authored and Mehul Kar committed May 20, 2023
    Configuration menu
    Copy the full SHA
    405bbbf View commit details
    Browse the repository at this point in the history

  5. comments

    Mehul Kar authored and Mehul Kar committed May 20, 2023
    Configuration menu
    Copy the full SHA
    5a45008 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Update cli/internal/runcache/runcache.go 

    Co-authored-by: Nicholas Yang <[email protected]>
    @mehulkar @NicholasLYang
    mehulkar and NicholasLYang authored May 23, 2023
    Configuration menu
    Copy the full SHA
    b08e291 View commit details
    Browse the repository at this point in the history

  2. Use const for cache source noop

    Mehul Kar authored and Mehul Kar committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a798459 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Use CacheMiss helper for noop implementation

    @mehulkar
    Mehul Kar authored and mehulkar committed May 25, 2023
    Configuration menu
    Copy the full SHA
    320a368 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mehulkar/turbo-1000-runs-include-timesaved-f… 

    …or-local-runs
    @mehulkar
    mehulkar committed May 25, 2023
    Configuration menu
    Copy the full SHA
    46fc3f4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Store and retrieve timeSaved value from daemon (#5101) 

    Co-authored-by: Chris Olszewski <[email protected]>
    @mehulkar @chris-olszewski
    mehulkar and chris-olszewski authored May 27, 2023
    Configuration menu
    Copy the full SHA
    2f1b9fd View commit details
    Browse the repository at this point in the history

  2. Remove debug statements

    @mehulkar
    mehulkar committed May 27, 2023
    Configuration menu
    Copy the full SHA
    d94af44 View commit details
    Browse the repository at this point in the history

  3. Fix linter

    @mehulkar
    mehulkar committed May 27, 2023
    Configuration menu
    Copy the full SHA
    8ea8c8a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge branch 'main' into mehulkar/turbo-1000-runs-include-timesaved-f… 

    …or-local-runs
    @mehulkar
    mehulkar authored May 30, 2023
    Configuration menu
    Copy the full SHA
    ea267a6 View commit details
    Browse the repository at this point in the history

  2. revert log message

    @mehulkar
    mehulkar committed May 30, 2023
    Configuration menu
    Copy the full SHA
    55105bc View commit details
    Browse the repository at this point in the history

  3. Remove Exists() check

    @mehulkar
    mehulkar committed May 30, 2023
    Configuration menu
    Copy the full SHA
    32296b8 View commit details
    Browse the repository at this point in the history

  4. set cache source to fs when skipping restoration

    @mehulkar
    mehulkar committed May 30, 2023
    Configuration menu
    Copy the full SHA
    5bc4f12 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Revert all the cacheStatus signature things

    @mehulkar
    mehulkar committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f5e8183 View commit details
    Browse the repository at this point in the history

  2. Revert the parts of runcache that aren't related to daemon get/set

    @mehulkar
    mehulkar committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e96c3bb View commit details
    Browse the repository at this point in the history