Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send task summaries as tasks finish #4913

Merged
merged 60 commits into from
May 16, 2023
Merged

Send task summaries as tasks finish #4913

merged 60 commits into from
May 16, 2023

Commits on May 12, 2023

  1. Create spacesClient struct to make requests to spaces 

    Also breaks down posting of tasks to per-task and removes the
parallelism feature, which we will implement differently in future
commits.
    @mehulkar
    Turbobot authored and mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5855a25 View commit details
    Browse the repository at this point in the history

  2. Post run start at the beginning of the run

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d3efd08 View commit details
    Browse the repository at this point in the history

  3. Close/POST tasks as they finish

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9c04987 View commit details
    Browse the repository at this point in the history

  4. Remove wrapper method for PATCH request

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f8bdc26 View commit details
    Browse the repository at this point in the history

  5. Remove api client from runsummary struct, only used by spaces client

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    87647e0 View commit details
    Browse the repository at this point in the history

  6. Move constants to the file they are used in

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d9e7775 View commit details
    Browse the repository at this point in the history

  7. Put all errors in the same place, no need to distinguish

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    02bef6a View commit details
    Browse the repository at this point in the history

  8. Make requests via a goroutine and wait on all requests to be done

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    dcf3001 View commit details
    Browse the repository at this point in the history

  9. Add another error condition

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    195116e View commit details
    Browse the repository at this point in the history

  10. Make unlinked error generic and consolidate to one place

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ea92a70 View commit details
    Browse the repository at this point in the history

  11. Always decrement waitgroup counter if we're throwing away request

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0d17035 View commit details
    Browse the repository at this point in the history

  12. Make error/help message for linking better

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a1cc4da View commit details
    Browse the repository at this point in the history

  13. Better error method

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8e60c59 View commit details
    Browse the repository at this point in the history

  14. Remove extranneous check

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    26480f3 View commit details
    Browse the repository at this point in the history

  15. Move erorr making to req struct instance

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    dedb97e View commit details
    Browse the repository at this point in the history

  16. Consistent error and debug messages

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5f59f5d View commit details
    Browse the repository at this point in the history

  17. Lazily compute req urls and set response on onDone handler

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1601f99 View commit details
    Browse the repository at this point in the history

  18. Block all requests on the first run POST request

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    39d7e89 View commit details
    Browse the repository at this point in the history

  19. Shuffle methods around for readability

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d05ea23 View commit details
    Browse the repository at this point in the history

  20. give spacesClient access to rsm

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b67511b View commit details
    Browse the repository at this point in the history

  21. Consolidate error msg when there is no spaceId

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    37a183c View commit details
    Browse the repository at this point in the history

  22. Remove redundant check for runID when posting tasks

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c7ee5b3 View commit details
    Browse the repository at this point in the history

  23. Better comments

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d96d4b1 View commit details
    Browse the repository at this point in the history

  24. Standardized error message

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    50d1adf View commit details
    Browse the repository at this point in the history

  25. check for run id first so error messages wont be duplicated

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d24bec7 View commit details
    Browse the repository at this point in the history

  26. Parallelize requests into 8 goroutines

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    be6c9cd View commit details
    Browse the repository at this point in the history

  27. Use a single wait group

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e3cb144 View commit details
    Browse the repository at this point in the history

  28. reduce diff

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c98a04f View commit details
    Browse the repository at this point in the history

  29. remove unnecessary wrapper method

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d74acd8 View commit details
    Browse the repository at this point in the history

  30. Move the signal internal to spaceRun

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9722fe8 View commit details
    Browse the repository at this point in the history

  31. TODO notes

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c6c4439 View commit details
    Browse the repository at this point in the history

  32. wait for run create channel to close as new requests come in, not before

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    46382dc View commit details
    Browse the repository at this point in the history

  33. Use req.error for unmarshal error

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ff223fe View commit details
    Browse the repository at this point in the history

  34. Remove error return, we just log errors

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2e91229 View commit details
    Browse the repository at this point in the history

  35. rearrange

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    03f4d78 View commit details
    Browse the repository at this point in the history

  36. make explicit start()

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2260f6d View commit details
    Browse the repository at this point in the history

  37. Make requests in goroutine so they are not blocking when they do star… 

    …t executing
    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    867e4c4 View commit details
    Browse the repository at this point in the history

  38. comments

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    95a9c63 View commit details
    Browse the repository at this point in the history

  39. Use Duration method instead of manually calculating duration

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    73e354a View commit details
    Browse the repository at this point in the history

  40. move spaceID into spacesClient struct

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    abeab8f View commit details
    Browse the repository at this point in the history

  41. Skip all requests if there is no spaceId

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0d41fea View commit details
    Browse the repository at this point in the history

  42. Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-… 

    …as-tasks-finish
    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    72d1457 View commit details
    Browse the repository at this point in the history

  43. Remove bidirectional relationship

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    580255e View commit details
    Browse the repository at this point in the history

  44. better comments

    @mehulkar
    mehulkar committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c1bb83a View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Fix goroutine setup for async task requests (#4924) 

    Setup a pending queue so adding new requests doesn't block
task execution.
    @mehulkar
    mehulkar committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0159de9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-… 

    …as-tasks-finish
    @mehulkar
    mehulkar committed May 15, 2023
    Configuration menu
    Copy the full SHA
    01a3860 View commit details
    Browse the repository at this point in the history

  3. Wait for requests to complete before closing channel

    @mehulkar
    mehulkar committed May 15, 2023
    Configuration menu
    Copy the full SHA
    62041c0 View commit details
    Browse the repository at this point in the history

  4. separate data from resources

    @mehulkar
    mehulkar committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6a454db View commit details
    Browse the repository at this point in the history

  5. Improve code comments

    @mehulkar
    mehulkar committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7b3b663 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-… 

    …as-tasks-finish
    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2f6521a View commit details
    Browse the repository at this point in the history

  2. Remove unused field

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f771e8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-… 

    …as-tasks-finish
    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c9174ec View commit details
    Browse the repository at this point in the history

  4. Check whether spaces is enabled earlier and fewer times

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    eb30ac3 View commit details
    Browse the repository at this point in the history

  5. remove extranneous check for spaceId

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    682630f View commit details
    Browse the repository at this point in the history

  6. use .enabled consistently

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    cf4e598 View commit details
    Browse the repository at this point in the history

  7. Check for linked repo once and disable client if no link

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1937654 View commit details
    Browse the repository at this point in the history

  8. Print errors when disabled

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    8e8085c View commit details
    Browse the repository at this point in the history

  9. nothing

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ae3d8d6 View commit details
    Browse the repository at this point in the history

  10. Handle edge case of channel being closed before the reuqest is done

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1393df5 View commit details
    Browse the repository at this point in the history

  11. only add error for missing link if spaces is enabled

    @mehulkar
    mehulkar committed May 16, 2023
    Configuration menu
    Copy the full SHA
    110bcd8 View commit details
    Browse the repository at this point in the history