Run prettier in individual workspaces #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: ci
area: site
pkg: create-turbo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
Merged
|
Benchmark for 0f42e66Click to view benchmark
|
mehulkar
requested review from
tknickman and
NicholasLYang
and removed request for
a team
nathanhammond
suggested changes
Feb 23, 2023
mehulkar
force-pushed
the
mehulkar/turbo-830-run-prettier-in-individual-workspaces
branch
from
fcb3820
to
d5ea4e6
Compare
mehulkar
force-pushed
the
mehulkar/turbo-830-run-prettier-in-individual-workspaces
branch
from
d5ea4e6
to
1a9349b
Compare
|
✅ This change can build |
mehulkar
force-pushed
the
mehulkar/turbo-830-run-prettier-in-individual-workspaces
branch
from
1a9349b
to
e0da41f
Compare
Linux Benchmark for 1e1aeb9
Click to view full benchmark
|
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again. Bot CommandsTo ignore an alert, reply with a comment starting with
🧐 Potential typo squatPackage name is similar to other popular packages and may not be the package you want. Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages. Pull request alert summary
|
Linux Benchmark for ca77034Click to view benchmark
|
MacOS Benchmark for ca77034
Click to view full benchmark
|
Windows Benchmark for ca77034
Click to view full benchmark
|
mehulkar
force-pushed
the
mehulkar/turbo-830-run-prettier-in-individual-workspaces
branch
from
2a779c3
to
e4690e1
Compare
Linux Benchmark for edb633fClick to view benchmark
|
|
The failing tests are because cli tests are running in the JS package workflow, when that workflow doesn't provision Go/Rust setup. This was reverted in 4e035e6, so this failure would be fine if I updated the branch. But I don't want to wait for another round of CI checks if I do that. |
mehulkar
deleted the
mehulkar/turbo-830-run-prettier-in-individual-workspaces
branch
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
lint:prettiertask in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably thebenchmark/workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)Note: adding this granularity immediately calls attention to the fact that we need some way to audit which workspaces may have forgotten to implement the script.