-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run prettier in individual workspaces #3925
Run prettier in individual workspaces #3925
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Benchmark for 0f42e66Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehulkar checking in on this one - I can take another look once conflicts are resolved if we still want to get it in
fcb3820
to
d5ea4e6
Compare
d5ea4e6
to
1a9349b
Compare
✅ This change can build |
1a9349b
to
e0da41f
Compare
Linux Benchmark for 1e1aeb9
Click to view full benchmark
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again. Bot CommandsTo ignore an alert, reply with a comment starting with
🧐 Potential typo squatPackage name is similar to other popular packages and may not be the package you want. Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages. Pull request alert summary
|
Linux Benchmark for ca77034Click to view benchmark
|
MacOS Benchmark for ca77034
Click to view full benchmark
|
Windows Benchmark for ca77034
Click to view full benchmark
|
2a779c3
to
e4690e1
Compare
Linux Benchmark for edb633fClick to view benchmark
|
The failing tests are because cli tests are running in the JS package workflow, when that workflow doesn't provision Go/Rust setup. This was reverted in 4e035e6, so this failure would be fine if I updated the branch. But I don't want to wait for another round of CI checks if I do that. |
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
This adds a `lint:prettier` task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably the `benchmark/` workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)
This adds a
lint:prettier
task in each workspace so that we can get the benefits of a granular cache and when running prettier, we don't have to run it across the entire monorepo (notably thebenchmark/
workspace which is very slow to run prettier on, and rarely changes -- an ideal candidate for a cache hit)Note: adding this granularity immediately calls attention to the fact that we need some way to audit which workspaces may have forgotten to implement the script.