-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ui): limit viewport size based on term size (#7837)
### Description With #7822 (and #7805 ) we're using `insert_before` to persist logs. This can panic (ratatui/ratatui#999) if the viewport fills the entire terminal. This PR changes our viewport construction so it now takes terminal size into account. (Previously we always would use 60, even if the terminal didn't have 60 rows) ### Testing Instructions Use UI with a terminal that has a height of 60 or less. Closes TURBO-2695
- Loading branch information
1 parent
5bf78f6
commit c46afd6
Showing
2 changed files
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters