Transient tasks #8764
Open
Transient tasks #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This was referenced Jul 16, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sokra
changed the title
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
sokra
force-pushed
the
sokra/improve-task-input
branch
from
8f0000c
to
d13a797
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
5e4b8d7
to
3488490
Compare
|
sokra
force-pushed
the
sokra/improve-task-input
branch
from
d13a797
to
f2892be
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
3488490
to
8b2e404
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
8b2e404
to
79ae4b8
Compare
sokra
force-pushed
the
sokra/improve-task-input
branch
from
6a2b023
to
4c95906
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
79ae4b8
to
84301f5
Compare
sokra
force-pushed
the
sokra/improve-task-input
branch
from
4c95906
to
47efbda
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
84301f5
to
d43625e
Compare
sokra
force-pushed
the
sokra/improve-task-input
branch
from
647470f
to
a97d97a
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
f0f3d2a
to
6fdd5a5
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
6fdd5a5
to
01eecb3
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
01eecb3
to
e3616fc
Compare
sokra
force-pushed
the
sokra/transient-tasks
branch
from
e3616fc
to
e3e5fc7
Compare
sokra
commented
Jul 24, 2024
| @@ -77,6 +77,14 @@ impl Debug for TaskId { | |||
| } | |||
| } | |||
|
|
|||
| pub const TRANSIENT_TASK_BIT: u32 = 0x8000_0000; | |||
There was a problem hiding this comment.
We could go for 0xc000_0000 if we need more space for persistent tasks. That would work with the system, but I keep it in the middle for now
Rename PersistentTaskType -> CachedTaskType
sokra
force-pushed
the
sokra/transient-tasks
branch
from
e3e5fc7
to
5422e84
Compare
bgw
approved these changes
Jul 26, 2024
| @@ -292,6 +319,74 @@ impl MemoryBackend { | |||
| pub fn task_statistics(&self) -> &TaskStatisticsApi { | |||
| &self.task_statistics | |||
| } | |||
|
|
|||
| fn track_cache_hit( | |||
There was a problem hiding this comment.
Thanks for moving my garbage out into a separate function!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track which tasks are transient and which are persistent. We need to track that for persistent caching.
We used a different task id space for transient tasks so they don't use up persistent ids and to easily identify transient tasks.
Testing Instructions