Drop excessive cells after task reexecution #8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
✅ This change can build |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
sokra
force-pushed
the
sokra/excessive-cells
branch
from
427f999
to
64b1e46
Compare
sokra
force-pushed
the
sokra/excessive-cells
branch
from
64b1e46
to
91c44f9
Compare
This was referenced Jul 15, 2024
sokra
force-pushed
the
sokra/excessive-cells
branch
from
91c44f9
to
0967bee
Compare
sokra
force-pushed
the
sokra/excessive-cells
branch
from
0967bee
to
0e94bb4
Compare
arlyon
reviewed
Jul 17, 2024
| @@ -325,6 +324,7 @@ impl Backend for MemoryBackend { | |||
| task_id: TaskId, | |||
| duration: Duration, | |||
| memory_usage: usize, | |||
| cell_counters: AutoMap<ValueTypeId, u32, BuildHasherDefault<FxHasher>, 8>, | |||
There was a problem hiding this comment.
Unrelated but it would be useful to log the max size of each of these items perhaps in the tracing mode @bgw built? It's hard as a reviewer to understand memory impact sometimes.
arlyon
reviewed
Jul 17, 2024
| /// Access to a cell. | ||
| pub(crate) fn with_cell_mut<T>( | ||
| /// Read a cell. | ||
| pub(crate) fn read_cell( |
There was a problem hiding this comment.
Bikeshedding but I prefer with_cell and with_cell_mut even it it not supposed to return anything
sokra
force-pushed
the
sokra/box-scheduled
branch
from
b15889a
to
7e73710
Compare
sokra
force-pushed
the
sokra/excessive-cells
branch
from
f7ec54f
to
ade4ad5
Compare
sokra
force-pushed
the
sokra/box-scheduled
branch
2 times, most recently
from
b89925f
to
300252a
Compare
sokra
force-pushed
the
sokra/excessive-cells
branch
from
ade4ad5
to
3589b2e
Compare
When cells become unused after recomputation of a task, drop them.
sokra
force-pushed
the
sokra/excessive-cells
branch
from
3589b2e
to
6fda947
Compare
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description When cells become unused after recomputation of a task, drop them. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description When cells become unused after recomputation of a task, drop them. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description When cells become unused after recomputation of a task, drop them. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
NicholasLYang
pushed a commit
that referenced
this pull request
Jul 31, 2024
When cells become unused after recomputation of a task, drop them. <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description When cells become unused after recomputation of a task, drop them. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
NicholasLYang
pushed a commit
that referenced
this pull request
Aug 1, 2024
When cells become unused after recomputation of a task, drop them. <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cells become unused after recomputation of a task, drop them.
Testing Instructions