ci: parallelize Examples tests with turbo #4929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
mehulkar
changed the title
|
This comment was marked as outdated.
This comment was marked as outdated.
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
178e5e7
to
676e97c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
676e97c
to
6b6b4b1
Compare
mehulkar
commented
May 16, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
mehulkar
force-pushed
the
mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests
branch
from
874378c
to
cb06a3e
Compare
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
5fb11bc
to
4d35cd1
Compare
turbo-orchestrator
bot
added
the
area: examples
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
dfa67d8
to
eb5420f
Compare
turbo-orchestrator
bot
removed
the
area: examples
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
eb5420f
to
2ecf9e0
Compare
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
2ecf9e0
to
b84f02d
Compare
mehulkar
force-pushed
the
mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests
branch
from
cb06a3e
to
723aa4d
Compare
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
b84f02d
to
541de93
Compare
Linux Benchmark for 6a938e5Click to view benchmark
|
mehulkar
force-pushed
the
mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests
branch
from
723aa4d
to
c620266
Compare
mehulkar
changed the base branch from
mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests
to
main
Linux Benchmark for 8856f79
Click to view full benchmark
|
MacOS Benchmark for 8856f79
Click to view full benchmark
|
This setup will allow turbo to parallelize and cache execution of these tests. It also reduces the number of Github Workflow runs that are triggered when an example changes, greatly reducing the amount of computing power required to run the tests. This commit does not change the fact that all examples tests are run when any of the examples change. We may be able to wire up dependencies more carefully in the future, but this is not feasible at the moment because each example itself is not a workspace.
mehulkar
force-pushed
the
mk/examples-parallel-via-turbo
branch
from
397ee7a
to
f9cec7d
Compare
Linux Benchmark for 1100d6aClick to view benchmark
|
|
Closing in favor of #5011, because of so much noise from automation in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #4190. There is more boilerplate, but it models each test of an example as its own workspace, so turbo can parallelize its execution. If when/we turn on remote caching in CI that will help even more.
Reviewer notes (please read 😄 )
examples/andexamples-tests/**. Since these tests do not exercise a locally built turbo, this is fine. In the future we may want to run examples tests against CLI changes as well, but we will cross that bridge when we get there.examples/directory itself is a single workspace, any change to any example will cause a cache miss on all examples-tests. This is not ideal, but I'm not attempting to solve that here.npmwith thewith-yarn). I'm not planning to change/delete those in this PR, unless I've translated the matrix wrong.