Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pnpm to 9.1.0 #64945

Open
wants to merge 5 commits into
base: canary
Choose a base branch
from
Open

chore: update pnpm to 9.1.0 #64945

wants to merge 5 commits into from

Conversation

samcx
Copy link
Member

@samcx samcx commented Apr 23, 2024

Notable change of v9 is Corepack is enabled by default.
So we can ensure all package manage/resolved exact same version of pnpm.

  • v9.0.0: Discontinued support for Node.js v16 and introduced Corepack compatibility checks. New configuration updates include enabling dedupe-injected-deps and changing the lockfile to version 9, with better readability and resistance to Git conflicts.

...

Closes NEXT-3211

@samcx samcx self-assigned this Apr 23, 2024
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team tests labels Apr 23, 2024
@samcx samcx marked this pull request as ready for review April 23, 2024 20:40
@samcx samcx requested review from molebox and delbaoliveira and removed request for a team April 23, 2024 20:40
Copy link

socket-security bot commented Apr 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] environment +8 160 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 16.8 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 15.8 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem Transitive: shell, unsafe +93 6.63 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 262 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +11 3.06 MB nicolo-ribaudo
npm/@babel/[email protected] environment +3 2.5 MB nicolo-ribaudo
npm/@playwright/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +3 10.3 MB yurys
npm/@rushstack/[email protected] None 0 240 kB odspnpm
npm/@types/[email protected] None 0 33 kB types
npm/@types/[email protected] None 0 11.4 kB types
npm/@types/[email protected] None 0 6.41 kB types
npm/@types/[email protected] None 0 84.1 kB types
npm/@types/[email protected] None +1 9.65 kB types
npm/@types/[email protected] None 0 13.5 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/[email protected] None 0 5.21 kB leerobinson
npm/[email protected] environment, filesystem Transitive: shell +3 122 kB ai
npm/[email protected] None 0 2.05 MB caniuse-lite
npm/[email protected] environment 0 26.1 kB sibiraj-s
npm/[email protected] None 0 10.5 kB dougwilson
npm/[email protected] Transitive: environment, filesystem, unsafe +12 609 kB jounqin
npm/[email protected] Transitive: eval +95 7.4 MB ljharb
npm/[email protected] filesystem +13 358 kB mrmlnc
npm/[email protected] None +7 154 kB charlesrea
npm/[email protected] None 0 20.3 kB lukeed
npm/[email protected] None 0 4.35 MB ichernev
npm/[email protected] None 0 24.4 kB ai
npm/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +115 1.21 GB vercel-release-bot
npm/[email protected] None 0 108 kB blakeembrey
npm/[email protected] None 0 33.5 kB google-wombot
npm/[email protected] None 0 27.9 kB benjamn
npm/[email protected] Transitive: environment +1 658 kB vercel-release-bot
npm/[email protected] environment, filesystem +7 355 kB isaacs
npm/[email protected] None 0 112 kB faisalman
npm/[email protected] environment, filesystem +1 74.3 kB evilebottnawi

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Apr 23, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@samcx samcx enabled auto-merge (squash) April 23, 2024 20:42
@samcx samcx disabled auto-merge April 23, 2024 20:44
@KagamiChan
Copy link
Contributor

KagamiChan commented Apr 23, 2024

Hi @samcx Do you think if we could update the husky files to use corepack?
for example:

 #!/usr/bin/env sh
 . "$(dirname -- "$0")/_/husky.sh"
 
-pnpm lint-staged
+corepack pnpm lint-staged

I have to modify that to allow lint stage my commits as pnpm version on my machine does not match

@ryota-murakami
Copy link
Contributor

@samcx thx!

@samcx samcx changed the title chore: update pnpm to 9.0.5 chore: update pnpm to 9.0.6 Apr 24, 2024
@samcx
Copy link
Member Author

samcx commented Apr 24, 2024

@KagamiChan We should add that in a separate :pr: !

@samcx
Copy link
Member Author

samcx commented Apr 24, 2024

@samcx samcx changed the title chore: update pnpm to 9.0.6 chore: update pnpm to 9.1.0 May 7, 2024
@samcx
Copy link
Member Author

samcx commented May 7, 2024

It looks like we can't land this until this is fixed → pnpm/pnpm#7997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants