New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pnpm to 9.1.0 #64945
base: canary
Are you sure you want to change the base?
chore: update pnpm to 9.1.0 #64945
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Hi @samcx Do you think if we could update the husky files to use corepack? #!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
-pnpm lint-staged
+corepack pnpm lint-staged I have to modify that to allow lint stage my commits as pnpm version on my machine does not match |
@samcx thx! |
@KagamiChan We should add that in a separate |
Something is up with https://github.com/vercel/next.js/blob/canary/.github/workflows/test_e2e_deploy_related.yml—not seeing it locally when running |
It looks like we can't land this until this is fixed → pnpm/pnpm#7997 |
Notable change of v9 is Corepack is enabled by default.
So we can ensure all package manage/resolved exact same version of pnpm.
dedupe-injected-deps
and changing the lockfile to version 9, with better readability and resistance to Git conflicts....
v9.1.0
Kudos to @ryota-murakami for the original ! → chore: update [email protected] #64854
Closes NEXT-3211