refactor: more precise types for req/res in withRequestStore (#70357)

- removes IncomingMessage/ServerResponse from accepted types, we never
actually pass those
- narrow down the possible combinations of req/res to what we actually
use

packages/next/src/server/async-storage/with-request-store.ts

@@ -1,5 +1,5 @@
 import type { BaseNextRequest, BaseNextResponse } from '../base-http'
-import type { IncomingHttpHeaders, IncomingMessage, ServerResponse } from 'http'
+import type { IncomingHttpHeaders } from 'http'
 import type { AsyncLocalStorage } from 'async_hooks'
 import type { RequestStore } from '../../client/components/request-async-storage.external'
 import type { RenderOpts } from '../app-render/types'
@@ -55,8 +55,7 @@ export type WrapperRenderOpts = RequestLifecycleOpts &
     previewProps?: __ApiPreviewProps
   }
 
-export type RequestContext = {
-  req: IncomingMessage | BaseNextRequest | NextRequest
+export type RequestContext = RequestResponsePair & {
   /**
    * The URL of the request. This only specifies the pathname and the search
    * part of the URL. This is only undefined when generating static paths (ie,
@@ -74,12 +73,15 @@ export type RequestContext = {
      */
     search?: string
   }
-  res?: ServerResponse | BaseNextResponse
   renderOpts?: WrapperRenderOpts
   isHmrRefresh?: boolean
   serverComponentsHmrCache?: ServerComponentsHmrCache
 }
 
+type RequestResponsePair =
+  | { req: BaseNextRequest; res: BaseNextResponse } // for an app page
+  | { req: NextRequest; res: undefined } // in an api route or middleware
+
 /**
  * If middleware set cookies in this request (indicated by `x-middleware-set-cookie`),
  * then merge those into the existing cookie object, so that when `cookies()` is accessed

packages/next/src/server/route-modules/app-route/module.ts

@@ -276,6 +276,7 @@ export class AppRouteRouteModule extends RouteModule<
     // Get the context for the request.
     const requestContext: RequestContext = {
       req: rawRequest,
+      res: undefined,
       url: rawRequest.nextUrl,
       renderOpts: {
         previewProps: context.prerenderManifest.preview,

packages/next/src/server/web/adapter.ts

@@ -238,6 +238,7 @@ export async function adapter(
               requestAsyncStorage,
               {
                 req: request,
+                res: undefined,
                 url: request.nextUrl,
                 renderOpts: {
                   onUpdateCookies: (cookies) => {