Skip to content

Commit

Permalink
Update RawOutput API (vercel/turborepo#8075)
Browse files Browse the repository at this point in the history
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with #65300

Closes PACK-3034
  • Loading branch information
bgw authored May 8, 2024
1 parent f8dc86b commit d985c1e
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions crates/turbopack-core/src/raw_output.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use turbo_tasks::Vc;
use turbo_tasks_fs::FileSystemPath;

use crate::{
asset::{Asset, AssetContent},
Expand All @@ -11,14 +12,15 @@ use crate::{
/// This module has no references to other modules.
#[turbo_tasks::value]
pub struct RawOutput {
path: Vc<FileSystemPath>,
source: Vc<Box<dyn Source>>,
}

#[turbo_tasks::value_impl]
impl OutputAsset for RawOutput {
#[turbo_tasks::function]
fn ident(&self) -> Vc<AssetIdent> {
self.source.ident()
AssetIdent::from_path(self.path)
}
}

Expand All @@ -33,7 +35,7 @@ impl Asset for RawOutput {
#[turbo_tasks::value_impl]
impl RawOutput {
#[turbo_tasks::function]
pub fn new(source: Vc<Box<dyn Source>>) -> Vc<RawOutput> {
RawOutput { source }.cell()
pub fn new(path: Vc<FileSystemPath>, source: Vc<Box<dyn Source>>) -> Vc<RawOutput> {
RawOutput { path, source }.cell()
}
}

0 comments on commit d985c1e

Please sign in to comment.