Skip to content

Commit

Permalink
Upgrade lightningcss, disable grid scoping (vercel/turborepo#8176)
Browse files Browse the repository at this point in the history
### Description

Implements
https://github.com/parcel-bundler/lightningcss/pull/739/files.

Grid scoping in CSS Modules is disabled because Webpack CSS Modules
handling doesn't handle grid currently. This ensures moving from Webpack
to Turbopack doesn't have mismatching behavior around CSS grid.

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
  • Loading branch information
timneutkens authored May 21, 2024
1 parent 27f6255 commit 3c7fb4e
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 14 deletions.
4 changes: 4 additions & 0 deletions crates/turbopack-css/src/process.rs
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,8 @@ async fn process_content(
],
},
dashed_idents: false,
grid: false,
..Default::default()
}),

_ => None,
Expand Down Expand Up @@ -1227,6 +1229,8 @@ mod tests {
css_modules: Some(lightningcss::css_modules::Config {
pattern: Pattern::default(),
dashed_idents: false,
grid: false,
..Default::default()
}),
..Default::default()
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3c7fb4e

Please sign in to comment.