Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gaze with chokidar for config watcher #1946

Merged
merged 3 commits into from
Aug 12, 2017
Merged

Conversation

albinekb
Copy link
Contributor

Hopefully fix #1910

@matheuss
Copy link
Member

@albinekb can you elaborate? How it would fix it?

@albinekb
Copy link
Contributor Author

albinekb commented Jun 20, 2017

@Stanzilla
Copy link
Contributor

This should go in before a release, see #1960 (comment)
@albinekb what is missing here before it can be merged?

@timothyis timothyis requested a review from matheuss July 11, 2017 17:57
@ppot
Copy link
Contributor

ppot commented Aug 10, 2017

@albinekb ?

@leo leo merged commit be8e0cc into vercel:master Aug 12, 2017
@leo
Copy link
Contributor

leo commented Aug 12, 2017

Just tested this locally on Windows with a friend and concluded that it's definitely needed. He's been using a custom build for some time now (based on this PR)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants