Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Support Python 3.13 #3591

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

ci: Support Python 3.13 #3591

wants to merge 14 commits into from

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Sep 14, 2024

Resolves #3587

Minimal/fallback support for 3.13.

Ideally I'd like to minimise hard dependencies we have on typing_extensions before October 2024. However, this would be the simpler option if it passes CI

Minimal/fallback support for `3.13`.

Ideally I'd like to minimise hard dependencies we have on `typing_extensions` before October 2024.
However, this would be the simpler option if it passes CI

Resolves #3587
@dangotbanned dangotbanned self-assigned this Oct 14, 2024
@mattijn
Copy link
Contributor

mattijn commented Oct 25, 2024

I think it is noble to wait for support for python 3.13 for all our upstream soft dependencies. But I'm also not against releasing before all our soft dependencies provide support (in my understanding pyarrow). What you think @dangotbanned?

@dangotbanned
Copy link
Member Author

I think it is noble to wait for support for python 3.13 for all our upstream soft dependencies. But I'm also not against releasing before all our soft dependencies provide support (in my understanding pyarrow). What you think @dangotbanned?

@mattijn nothing noble here 😄

I'm happy with releasing before pyarrow>=18.0.0 in principle.
The issue is we'd need to remove pyarrow from altair[all] (https://github.com/vega/altair/actions/runs/11448782729/job/31853033909?pr=3591)

Also maybe do some decoupling in tests/., if there are any imports that assume pyarrow is always installed.

Doing either of those is fine with me if you'd like to give it a try?


Personally though, I've got a few issues/PRs that I'd rather have ready for 5.5.0 (+ some others that are less pressing):

I think there's more value in delivering some/all of these vs a slightly earlier 5.5.0, if that makes sense?

@mattijn
Copy link
Contributor

mattijn commented Oct 25, 2024

Hmpf. Decoupling altair[all] is not something I was aiming for. Let's wait.

@dangotbanned
Copy link
Member Author

Hmpf. Decoupling altair[all] is not something I was aiming for. Let's wait.

No worries @mattijn

Also, IIRC pyarrow was blocking for geopandas - which I think is relevant to you?

@mattijn
Copy link
Contributor

mattijn commented Oct 25, 2024

Yeah, I assume that geospatial users of Altair are the minority, so if that's causing the delay, also feel a bit responsible for that.

@dangotbanned
Copy link
Member Author

Yeah, I assume that geospatial users of Altair are the minority, so if that's causing the delay, also feel a bit responsible for that.

Its not on you @mattijn!
just giving you a heads up if you were eager to use 3.13 is all

@dangotbanned
Copy link
Member Author

I'm all out of ideas on this one 😞

@mattijn @jonmmease @joelostblom @binste
Pinging in case any of you guys can make sense of the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing for Python 3.13
2 participants